Merge pull request #658 from brave/maxk-fix-crash-downloading

Fixes crashes when downloading an item (repro'd with a .crx)
brave · Oct 17, 2018 · cf050f4 · cf050f4
1 parent e0dc2c5
commit cf050f4
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/browser/ui/views/download/brave_download_item_view.cc b/browser/ui/views/download/brave_download_item_view.cc
@@ -81,7 +81,9 @@ void BraveDownloadItemView::OnDownloadUpdated(
  download::DownloadItem* download) {
  // Check for conditions that would disregard origin url change and fall back
  // onto base implementation to handle them.
- if (!model_.ShouldShowInShelf()) {
+ if (!model_.ShouldShowInShelf() ||
+ (DownloadItemView::download()->GetState() == DownloadItem::COMPLETE &&
+ model_.ShouldRemoveFromShelfWhenComplete())) {
  DownloadItemView::OnDownloadUpdated(download);
  return;
  }