Skip to content

Commit

Permalink
Move Leo specific strings to Brave grdp. (#20410)
Browse files Browse the repository at this point in the history
As the string is not overriding any Chromium strings, we should use our
own grdp. Previously, the auto generated file is touched manually,
and broke rebase pipeline.
  • Loading branch information
sangwoo108 authored Oct 5, 2023
1 parent fa85d6a commit df411fa
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 5 deletions.
2 changes: 1 addition & 1 deletion components/omnibox/browser/leo_provider.cc
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,10 @@

#include "brave/components/ai_chat/common/features.h"
#include "brave/components/omnibox/browser/leo_action.h"
#include "components/grit/brave_components_strings.h"
#include "components/omnibox/browser/autocomplete_input.h"
#include "components/omnibox/browser/autocomplete_match.h"
#include "components/omnibox/browser/autocomplete_provider_client.h"
#include "components/strings/grit/components_strings.h"
#include "third_party/metrics_proto/omnibox_input_type.pb.h"
#include "third_party/omnibox_proto/types.pb.h"
#include "ui/base/l10n/l10n_util.h"
Expand Down
4 changes: 0 additions & 4 deletions components/omnibox_strings.grdp
Original file line number Diff line number Diff line change
Expand Up @@ -287,8 +287,4 @@
<message name="IDS_OMNIBOX_ONE_LINE_CALCULATOR_SUGGESTION_TEMPLATE" desc="The string displayed when a calculator answer is suggested.">
<ph name="EXPRESSION">$1</ph> = <ph name="ANSWER">$2</ph>
</message>

<message name="IDS_OMNIBOX_ASK_LEO_DESCRIPTION" desc="The label in the omnibox explaning that the match item will open Leo">
Ask Leo
</message>
</grit-part>
3 changes: 3 additions & 0 deletions components/resources/omnibox_strings.grdp
Original file line number Diff line number Diff line change
Expand Up @@ -11,4 +11,7 @@
Open here button, press Enter to open this url in the current tab, instead of switching to the
existing tab
</message>
<message name="IDS_OMNIBOX_ASK_LEO_DESCRIPTION" desc="The label in the omnibox explaning that the match item will open Leo">
Ask Leo
</message>
</grit-part>

0 comments on commit df411fa

Please sign in to comment.