Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds support for non-verified flag #1042

Merged
merged 1 commit into from
Dec 18, 2018
Merged

Adds support for non-verified flag #1042

merged 1 commit into from
Dec 18, 2018

Conversation

NejcZdovc
Copy link
Contributor

@NejcZdovc NejcZdovc commented Dec 7, 2018

Resolves brave/brave-browser#2111

Native ledger: https://github.com/brave-intl/bat-native-ledger/pull/200/commits

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Verified that these changes build without errors on
    • Windows
    • macOS
    • Linux
  • Verified that these changes pass automated tests (npm test brave_unit_tests && npm test brave_browser_tests) on
    • Windows
    • macOS
    • Linux
  • Ran git rebase master (if needed).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.
  • Add appropriate QA labels (QA/Yes or QA/No) to include the closed issue in milestone

Test Plan:

  • enable rewards
  • visit slo-tech.com for 10s
  • make sure that this site is listed in the table
  • go to auto contribute settings
  • disable non verified sites
  • make sure that ac table reflects the change
  • visit 3zsistemi.si for 10s
  • make sure that is listed in the table
  • visit clifton.io for 10s
  • make sure that is not listed in the table
  • go to ac settings and enable non verified sites
  • make sure that both slo-tech.com and 3zsistemi.si are listed

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

@ryanml ryanml merged commit e17fded into master Dec 18, 2018
@ryanml ryanml deleted the non-verified branch December 18, 2018 18:17
ryanml added a commit that referenced this pull request Dec 18, 2018
Adds support for non-verified flag
@ryanml
Copy link
Contributor

ryanml commented Dec 18, 2018

0.61 (master): e17fded
0.60: 315a32b

NejcZdovc pushed a commit that referenced this pull request Jan 14, 2019
Adds support for non-verified flag
@bbondy bbondy added this to the 0.60.x - Dev milestone Jan 14, 2019
@srirambv
Copy link
Contributor

@NejcZdovc need clarrification
disable non verified sites
make sure that ac table reflects the change
visit 3zsistemi.si for 10s
make sure that is listed in the table - shouldn't list because disabled non verified sites in settings
visit clifton.io for 10s
make sure that is not listed in the table - should list because its a verified pub
go to ac settings and enable non verified sites
make sure that both slo-tech.com and 3zsistemi.si are listed - shouldnt it be slo-tech.com and clifton.io because 3zsistemi.si was logged when non-verified pubs was disabled

@NejcZdovc
Copy link
Contributor Author

@srirambv test plan is for staging where 3zsistemi.si is verified

@srirambv
Copy link
Contributor

Ah so as long as the verified and non-verified pubs are listed after enabling the allow non-verified pubs it should be fine right? I checked it against prod where 3zsistemi.si isnt verified but clifton.io is

@NejcZdovc
Copy link
Contributor Author

yup, just replace 3zsistemi.si with clifton.io in my test plan if checking on production

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow contributions to non-verified sites setting is not being respected
4 participants