Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use thisDeviceId to identify "This Device" #1100

Merged
merged 1 commit into from
Dec 14, 2018
Merged

Use thisDeviceId to identify "This Device" #1100

merged 1 commit into from
Dec 14, 2018

Conversation

darkdh
Copy link
Member

@darkdh darkdh commented Dec 14, 2018 •
edited
Loading

fix brave/brave-browser#2572

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Verified that these changes build without errors on
    • Windows
    • macOS
    • Linux
  • Verified that these changes pass automated tests (npm test brave_unit_tests && npm test brave_browser_tests) on
    • Windows
    • macOS
    • Linux
  • Ran git rebase master (if needed).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.
  • Add appropriate QA labels (QA/Yes or QA/No) to include the closed issue in milestone

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

@darkdh darkdh self-assigned this Dec 14, 2018
cezaraugusto
cezaraugusto approved these changes Dec 14, 2018
View reviewed changes
Copy link
Contributor

@cezaraugusto cezaraugusto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM like very good indeed I'd review this change 1000x

@darkdh darkdh merged commit d45f42c into master Dec 14, 2018
darkdh added a commit that referenced this pull request Dec 14, 2018
@darkdh
Merge pull request #1100 from brave/sync-v2-this-device
ee255ce 
Use thisDeviceId to identify "This Device"
@darkdh
Copy link
Member Author

darkdh commented Dec 14, 2018 •
edited
Loading

master: d45f42c
0.60.x: ee255ce
0.59.x: 8d0ee24
0.58.x: 373f8a0

@darkdh darkdh deleted the sync-v2-this-device branch December 14, 2018 23:12
darkdh added a commit that referenced this pull request Dec 15, 2018
@darkdh
Merge pull request #1100 from brave/sync-v2-this-device
8d0ee24 
Use thisDeviceId to identify "This Device"
darkdh added a commit that referenced this pull request Dec 15, 2018
@darkdh
Merge pull request #1100 from brave/sync-v2-this-device
373f8a0 
Use thisDeviceId to identify "This Device"
@bbondy bbondy added this to the 0.58.x - Release milestone Jan 14, 2019
fmarier pushed a commit that referenced this pull request Oct 29, 2019
@bbondy
Merge pull request #1100 from brave/default-brave-shields
cdc0543 
Add default Brave shield settings
petemill pushed a commit that referenced this pull request Jul 27, 2020
@bbondy
Merge pull request #1100 from brave/default-brave-shields
fe02790 
Add default Brave shield settings
petemill pushed a commit that referenced this pull request Jul 28, 2020
@bbondy
Merge pull request #1100 from brave/default-brave-shields
3d8a3a4 
Add default Brave shield settings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cezaraugusto cezaraugusto cezaraugusto approved these changes

Assignees

@darkdh darkdh

Labels
bug
Projects
None yet
Milestone
0.58.x - Release
Development

Successfully merging this pull request may close these issues.

This Device is put on the wrong row
3 participants
@darkdh @cezaraugusto @bbondy