Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sync: rename view sync code to view qr code and code words #1113

Merged
merged 1 commit into from
Dec 18, 2018

Conversation

cezaraugusto
Copy link
Contributor

@cezaraugusto cezaraugusto commented Dec 17, 2018

fix brave/brave-browser#2595

button is localed in the right-hand side of devices table

Test Plan:

  1. enable sync
  2. check that the button on the right-hand side of devices table has the words changed

@cezaraugusto cezaraugusto self-assigned this Dec 17, 2018
brave/brave-browser#2595
-
button is localed in the right-hand side of devices table
@cezaraugusto cezaraugusto merged commit 038adea into master Dec 18, 2018
@cezaraugusto cezaraugusto deleted the ca-2602 branch December 18, 2018 14:15
cezaraugusto added a commit that referenced this pull request Dec 18, 2018
sync: rename `view sync code` to `view qr code and code words`
@cezaraugusto
Copy link
Contributor Author

cezaraugusto commented Dec 18, 2018

master 038adea
0.60.x be2eb7c
0.59.x 98cee94

@rebron
Copy link
Collaborator

rebron commented Dec 20, 2018

Approving uplift-request for 0.59.x-beta. cc: @kjozwiak cc: @srirambv

darkdh pushed a commit that referenced this pull request Dec 20, 2018
sync: rename `view sync code` to `view qr code and code words`
@bbondy bbondy added this to the 0.59.x - Beta milestone Jan 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename "view sync code" to "view QR code and Code words" followup to #2549
4 participants