Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash with popup windows requesting Ethereum permission #11156

Merged
merged 1 commit into from
Nov 19, 2021
Merged

Conversation

bbondy
Copy link
Member

@bbondy bbondy commented Nov 18, 2021

Resolves brave/brave-browser#19566

I wasn't able to get a test case working quickly but I posted this issue to look at it again. I just want to get the fix in and uplifted for the next hotfix first. brave/brave-browser#19567

Looks like this:

Screen Shot 2021-11-18 at 1 47 39 PM

Submitter Checklist:

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@bbondy bbondy requested a review from darkdh November 18, 2021 18:46
@bbondy bbondy self-assigned this Nov 18, 2021
Copy link
Collaborator

@bridiver bridiver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deps ok

@srirambv
Copy link
Contributor

srirambv commented Nov 22, 2021

Verification passed on

Brave 1.34.28 Chromium: 96.0.4664.45 (Official Build) nightly (x86_64 translated)
Revision: 76e4c1bb2ab4671b8beba3444e61c0f17584b2fc-refs/branch-heads/4664@{#947}
OS macOS Version 12.0.1 (Build 21A559)
19566.mov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix crash when permission requests for Ethereum are from a popup window
4 participants