Fixes tipping report inconsistencies #1126
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: brave/brave-browser#2273
Fixes: brave/brave-browser#2332
Issue was that the call to fetch currentBalanceReport for these views was only happening on component mount, so if expected data to a bit to resolve, there was no retry. That was the primary issue with #2273
It makes sense that reports should be updated in sync with wallet props. Doing so resolves both of the above issues without any client side changes.
Submitter Checklist:
npm test brave_unit_tests && npm test brave_browser_tests
) ongit rebase master
(if needed).git rebase -i
to squash commits (if needed).Test Plan:
Defined in #2273 and #2332
Reviewer Checklist: