Issue 2252: Refactor the referrer hiding. #1240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iefremov
force-pushed
the
referrer_block
branch
from
4f150fd
to
ee2308c
Compare
|
TODO:
|
bridiver
reviewed
Jan 7, 2019
bridiver
reviewed
Jan 7, 2019
browser/net/brave_site_hacks_network_delegate_helper_unittest.cc
Outdated
Show resolved
Hide resolved
yrliou
reviewed
Jan 8, 2019
| referrer); | ||
| } | ||
|
|
||
|
|
There was a problem hiding this comment.
nit: Please remove the extra line.
|
|
||
| } // namespace | ||
|
|
||
|
|
iefremov
force-pushed
the
referrer_block
branch
2 times, most recently
from
b9efbe8
to
f7a53f4
Compare
|
it's easier to review per-commit, since I've clang-formatted one of the files. |
iefremov
force-pushed
the
referrer_block
branch
from
83914b2
to
07efa8b
Compare
added 5 commits
January 9, 2019 01:37
Fix #2252 Current solution for hiding the referer string requires readirecting literally all requests for which the referrer was modified. This approach conflicts with the fact that certain requests are not allowed to be redirected (i.e. CORS preflight requests). That said, current approach breaks a lot of sites. To refactor this we move the referrer hiding code to the earlier stage, where navigation requests are created and started. This is a convenient place to patch both renderer and browser initiated navigations and utilize ContentBrowserClient interface on the browser thread.
We have to keep this at least for a while, because we still want to hide referrers for all requests, including resource requests originated from renderer. But now we do not want to trigger internal redirects for each request to avoid CORS or any other issues.
iefremov
force-pushed
the
referrer_block
branch
from
07efa8b
to
71bc678
Compare
bbondy
approved these changes
Jan 8, 2019
bbondy
added a commit
that referenced
this pull request
Jan 8, 2019
Issue 2252: Refactor the referrer hiding.
bbondy
added a commit
that referenced
this pull request
Jan 8, 2019
Issue 2252: Refactor the referrer hiding.
This was referenced Jan 8, 2019
bbondy
added a commit
that referenced
this pull request
Jan 8, 2019
Issue 2252: Refactor the referrer hiding.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix brave/brave-browser#2252
Current solution for hiding the referer string requires readirecting literally
all requests for which the referrer was modified. This approach conflicts
with the fact that certain requests are not allowed to be redirected (i.e.
CORS preflight requests). That said, current approach breaks a lot of sites.
To refactor this we move the referrer hiding code to the earlier stage,
where navigation requests are created and started. This is a convenient
place to patch both renderer and browser initiated navigations and utilize
ContentBrowserClient interface on the browser thread.
Submitter Checklist:
npm test brave_unit_tests && npm test brave_browser_tests) ongit rebase master(if needed).git rebase -ito squash commits (if needed).Test Plan:
Reviewer Checklist: