Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce using a publisher proof for CRX3 #12551

Merged
merged 2 commits into from
Mar 16, 2022
Merged

Conversation

atuchin-m
Copy link
Collaborator

@atuchin-m atuchin-m commented Mar 9, 2022

For brave/brave-browser#873

This reverts CRX3 back to using CRX3_WITH_PUBLISHER_PROOF => enforce to check the extra signature.
The feature is added just in case to have ability to disable this verification remotely. I suggest deleting in a few weeks.

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@atuchin-m atuchin-m added this to the 1.38.x - Nightly milestone Mar 14, 2022
@atuchin-m atuchin-m merged commit 101d282 into master Mar 16, 2022
@atuchin-m atuchin-m deleted the enforce-crx3-publisher-proof branch March 16, 2022 10:54
muliswilliam pushed a commit that referenced this pull request Mar 16, 2022
* Enforce using a publisher proof for CRX3
* add a new line
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants