Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent loading brave scheme url from javascript #1263

Merged
merged 1 commit into from
Jan 8, 2019
Merged

Prevent loading brave scheme url from javascript #1263

merged 1 commit into from
Jan 8, 2019

Conversation

bbondy
Copy link
Member

@bbondy bbondy commented Jan 8, 2019

Uplift request for: #1196
Fix brave/brave-browser#2861
Fix brave/brave-browser#2849
Disclaimer: This is not my PR, I'm uplifting on behalf of @simonhong

@bbondy
Merge pull request #1196 from brave/prevent_brave_scheme_loading_from_js
eb96880 
Prevent loading brave scheme url from javascript
@bbondy bbondy added the 0.59.x label Jan 8, 2019
@bbondy bbondy self-assigned this Jan 8, 2019
kjozwiak
kjozwiak approved these changes Jan 8, 2019
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift to 0.59.x approved after deliberating with @rebron 👍 Please ensure that all appropriate issue(s) are also moved into the correct milestone.

@bbondy bbondy merged commit 52a2ec0 into 0.59.x Jan 8, 2019
@bbondy bbondy added this to the 0.59.x - Beta milestone Jan 14, 2019
@bsclifton bsclifton deleted the prevent_brave_scheme_loading_from_js-0.59.x branch January 24, 2019 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

@rebron rebron Awaiting requested review from rebron

@srirambv srirambv Awaiting requested review from srirambv

Assignees

@bbondy bbondy

Labels
None yet
Projects
None yet
Milestone
0.59.x - Release
Development

Successfully merging this pull request may close these issues.
2 participants
@bbondy @kjozwiak