Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes crash reporting not working on Windows 7. #1292

Merged
merged 1 commit into from
Jan 17, 2019

Conversation

mkarolin
Copy link
Collaborator

@mkarolin mkarolin commented Jan 11, 2019

Gives crashpad an option to use TLS 1.1 and 1.2 on Windows 7 and 8.0
in addition to TLS 1.0 used by WinHttp by default.

Fixes brave/brave-browser#1188

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Verified that these changes build without errors on
    • Windows
    • macOS
    • Linux
  • Verified that these changes pass automated tests (npm test brave_unit_tests && npm test brave_browser_tests) on
    • Windows
    • macOS
    • Linux
  • Ran git rebase master (if needed).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.
  • Add appropriate QA labels (QA/Yes or QA/No) to include the closed issue in milestone

Test Plan:

  1. Test on Windows 7 SP1 or on Windows 8;
  2. Start Brave browser with a fresh profile;
  3. Navigate to brave://settings, click on Advanced, then toggle Automatically send crash reports to Brave in the Privacy and security section to ON and click the Relaunch button that should have appeared next to the toggle;
  4. Wait for the browser to relaunch;
  5. Navigate to brave://crashes and verify that there are no crashes in the list;
  6. Open a new tab, in it navigate to brave://crash and wait for the "Aw, snap!" message on the page;
  7. Go back to the brave://crashes tab and reload it;
  8. Verify an entry on the page that indicates that the crash was uploaded (Uploaded Crash Report ID xxxxxxxxxx, as opposed to just Local Crash ID).

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

@bridiver
Copy link
Collaborator

is this also the case for Chrome on win7/8?

@mkarolin
Copy link
Collaborator Author

@bridiver, Chrome's crash reporting endpoint (clients2.google.com) accepts TLS 1.0, 1.1, and 1.2, so they don't have a problem.

@bridiver
Copy link
Collaborator

can we fix this in our endpoint?

@mkarolin
Copy link
Collaborator Author

I would imagine so, but I think we need @w0ts0n and/or @diracdeltas to chime in.

@diracdeltas
Copy link
Member

If i understand the bug correctly (our endpoint only supports tls 1.1 and above, windows 7 by default supports tls 1.0 at maximum) it would be preferable to upgrade windows TLS version rather than downgrade the server TLS version.

@mkarolin mkarolin self-assigned this Jan 11, 2019
@mkarolin mkarolin changed the title WIP: Fixes crash reporting not working on Windows 7. Fixes crash reporting not working on Windows 7. Jan 11, 2019
@bbondy bbondy added this to the 0.61.x - Nightly milestone Jan 14, 2019
@bbondy bbondy removed the 0.61.x label Jan 14, 2019
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@bsclifton bsclifton merged commit e23b30a into master Jan 17, 2019
@bsclifton bsclifton deleted the maxk-fix-win7-crashpad branch January 17, 2019 17:53
fmarier pushed a commit that referenced this pull request Oct 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

chrome://crashes not working under Win 7
5 participants