Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(wallet): Show Full Addresses in Tooltips #13210

Merged
merged 1 commit into from
Apr 29, 2022

Conversation

Douglashdaniel
Copy link
Contributor

@Douglashdaniel Douglashdaniel commented Apr 28, 2022

Description

Display's a Tooltip of truncated addresses for

  • Unstoppable/ENS domains
  • Confirm Transaction Panel
  • Transaction Details Panel
  • ERC20 Approve Panel

Resolves brave/brave-browser#22498

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

UD Tooltip, Confirm Transaction Tooltips, Transaction Details Tooltips

Screen.Recording.2022-04-28.at.3.13.33.PM.mov

ERC20 Approve Tooltip

Screen.Recording.2022-04-28.at.3.16.17.PM.mov

@Douglashdaniel Douglashdaniel self-assigned this Apr 28, 2022
@github-actions github-actions bot added the CI/storybook-url Deploy storybook and provide a unique URL for each build label Apr 28, 2022
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@Douglashdaniel Douglashdaniel changed the title chore(wallet): Show Full Addresses in Tooltips fix(wallet): Show Full Addresses in Tooltips Apr 29, 2022
@Douglashdaniel Douglashdaniel added this to the 1.40.x - Nightly milestone Apr 29, 2022
@Douglashdaniel Douglashdaniel merged commit c9388cc into master Apr 29, 2022
@Douglashdaniel Douglashdaniel deleted the show-full-addresses-in-tooltips branch April 29, 2022 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/storybook-url Deploy storybook and provide a unique URL for each build
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't validate UD wallet address.
4 participants