Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

only call Stop when DistillerPageWebContents::CreateNewWebContents is… #1363

Merged
merged 1 commit into from
Jan 16, 2019
Merged

only call Stop when DistillerPageWebContents::CreateNewWebContents is… #1363

merged 1 commit into from
Jan 16, 2019

Conversation

bridiver
Copy link
Collaborator

Original PR #1361

Fix brave/brave-browser#2991
Fix brave/brave-browser#2901

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Verified that these changes build without errors on
    • Windows
    • macOS
    • Linux
  • Verified that these changes pass automated tests (npm test brave_unit_tests && npm test brave_browser_tests) on
    • Windows
    • macOS
    • Linux
  • Ran git rebase master (if needed).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.
  • Add appropriate QA labels (QA/Yes or QA/No) to include the closed issue in milestone

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

@bridiver bridiver self-assigned this Jan 16, 2019
@bridiver bridiver requested a review from bbondy January 16, 2019 22:37
@bbondy bbondy added this to the 0.59.x - Beta milestone Jan 16, 2019
@bridiver bridiver merged commit f402995 into 0.59.x Jan 16, 2019
@bridiver bridiver deleted the issues/2901-0.59.x branch January 16, 2019 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bbondy bbondy bbondy approved these changes

Assignees

@bridiver bridiver

Labels
None yet
Projects
None yet
Milestone
0.59.x - Release
Development

Successfully merging this pull request may close these issues.
2 participants
@bridiver @bbondy