Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand font whitelist on macOS #13807

Merged
merged 3 commits into from
Jun 16, 2022
Merged

Conversation

pilgrim-brave
Copy link
Contributor

@pilgrim-brave pilgrim-brave commented Jun 15, 2022

Resolves brave/brave-browser#23489

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

See brave/brave-browser#23489 (comment)

@pilgrim-brave pilgrim-brave self-assigned this Jun 15, 2022
@pilgrim-brave pilgrim-brave requested a review from bridiver June 15, 2022 20:27
@pilgrim-brave pilgrim-brave added this to the 1.41.x - Nightly milestone Jun 15, 2022
@pilgrim-brave pilgrim-brave merged commit 0db7e55 into master Jun 16, 2022
@pilgrim-brave pilgrim-brave deleted the mpilgrim_expand_font_whitelist branch June 16, 2022 15:30
@pilgrim-brave pilgrim-brave restored the mpilgrim_expand_font_whitelist branch June 16, 2022 15:30
brave-builds pushed a commit that referenced this pull request Jun 16, 2022
brave-builds pushed a commit that referenced this pull request Jun 16, 2022
@kjozwiak kjozwiak deleted the mpilgrim_expand_font_whitelist branch June 17, 2022 17:10
@kjozwiak
Copy link
Member

Verification PASSED on macOS 12.4 Monterey x64 using the following build(s):

Brave | 1.42.4 Chromium: 103.0.5060.53 (Official Build) nightly (x86_64)
--- | ---
Revision | a1711811edd74ff1cf2150f36ffa3b0dae40b17f-refs/branch-heads/5060@{#853}
OS | macOS Version 12.4 (Build 21F79)
Shields Enabled Shields Disabled
Screen Shot 2022-06-18 at 1 56 05 PM Screen Shot 2022-06-18 at 1 56 20 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Shields breaking fonts on Feedly
3 participants