Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show singleton tabs for vpn manage urls #13882

Merged
merged 2 commits into from
Jun 23, 2022
Merged

Show singleton tabs for vpn manage urls #13882

merged 2 commits into from
Jun 23, 2022

Conversation

spylogsster
Copy link
Contributor

@spylogsster spylogsster commented Jun 21, 2022

Resolves brave/brave-browser#23100

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  • same steps from issue

@spylogsster spylogsster requested a review from bsclifton June 21, 2022 14:11
@spylogsster spylogsster self-assigned this Jun 21, 2022
@spylogsster spylogsster force-pushed the brave-23100 branch 2 times, most recently from 9e0e799 to 3880b39 Compare June 22, 2022 16:23
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great! Do you think we can add this same logic for the About Brave Firewall + VPN?
image

Maybe also the Privacy policy link on the tech support form too
image

bsclifton
bsclifton previously approved these changes Jun 23, 2022
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great! Thanks for adding the additional types 😄

@bsclifton bsclifton added this to the 1.42.x - Nightly milestone Jun 23, 2022
@bsclifton bsclifton merged commit 912791b into master Jun 23, 2022
@bsclifton bsclifton deleted the brave-23100 branch June 23, 2022 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Duplicate tabs shouldn't be possible for Manage subscription flows
2 participants