From 4a68e13fea218ecb7c9ce5d1ede88f6ae2e70350 Mon Sep 17 00:00:00 2001 From: Deep Date: Mon, 29 Aug 2022 18:02:30 -0400 Subject: [PATCH 1/2] Hide safe browsing option --- .../chrome/browser/privacy/settings/BravePrivacySettings.java | 1 + 1 file changed, 1 insertion(+) diff --git a/android/java/org/chromium/chrome/browser/privacy/settings/BravePrivacySettings.java b/android/java/org/chromium/chrome/browser/privacy/settings/BravePrivacySettings.java index bc9404de0d4d..61700e731bdf 100644 --- a/android/java/org/chromium/chrome/browser/privacy/settings/BravePrivacySettings.java +++ b/android/java/org/chromium/chrome/browser/privacy/settings/BravePrivacySettings.java @@ -243,6 +243,7 @@ public void onCreatePreferences(Bundle savedInstanceState, String rootKey) { removePreferenceIfPresent(PREF_SYNC_AND_SERVICES_LINK); removePreferenceIfPresent(PREF_NETWORK_PREDICTIONS); removePreferenceIfPresent(PREF_PRIVACY_SANDBOX); + removePreferenceIfPresent(PREF_SAFE_BROWSING); updateBravePreferences(); } From ecd8f8a95d22e59a4060763157c488fd0a094f5c Mon Sep 17 00:00:00 2001 From: Deep Date: Tue, 30 Aug 2022 15:06:42 -0400 Subject: [PATCH 2/2] Remove test for Safe browsing --- .../browser/privacy/settings/BravePrivacySettingsTest.java | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/android/javatests/org/chromium/chrome/browser/privacy/settings/BravePrivacySettingsTest.java b/android/javatests/org/chromium/chrome/browser/privacy/settings/BravePrivacySettingsTest.java index fdc733fdb219..29160fc6123b 100644 --- a/android/javatests/org/chromium/chrome/browser/privacy/settings/BravePrivacySettingsTest.java +++ b/android/javatests/org/chromium/chrome/browser/privacy/settings/BravePrivacySettingsTest.java @@ -72,7 +72,8 @@ public void testParentItems() { checkPreferenceExists(PREF_CLEAR_BROWSING_DATA); checkPreferenceExists(PREF_DO_NOT_TRACK); checkPreferenceExists(PREF_HTTPS_FIRST_MODE); - checkPreferenceExists(PREF_SAFE_BROWSING); + // TODO : Need to add back the test once we have fix ready for safe browsing + // checkPreferenceExists(PREF_SAFE_BROWSING); checkPreferenceExists(PREF_SECURE_DNS); checkPreferenceExists(PREF_INCOGNITO_LOCK); checkPreferenceExists(PREF_PHONE_AS_A_SECURITY_KEY);