Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Perform download safety check even when user is prompted for save location. #16969

Merged
merged 1 commit into from
Feb 3, 2023
Merged

Perform download safety check even when user is prompted for save location. #16969

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions chromium_src/chrome/browser/download/download_target_determiner.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
/* Copyright (c) 2023 The Brave Authors. All rights reserved.
* This Source Code Form is subject to the terms of the Mozilla Public
* License, v. 2.0. If a copy of the MPL was not distributed with this file,
* You can obtain one at https://mozilla.org/MPL/2.0/. */

// Prompting the user for download location shouldn't be a factor in determining
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm confused because this looks like an upstream issue if there is an issue here, but the location does affect the danger level which is why macOS prompts for permission to access different file system locations for each app

// the download's danger level.
#define BRAVE_DOWNLOAD_TARGET_DETERMINER_GET_DANGER_LEVEL \
true) {} \
if (

#include "src/chrome/browser/download/download_target_determiner.cc"
#undef BRAVE_DOWNLOAD_TARGET_DETERMINER_GET_DANGER_LEVEL
12 changes: 12 additions & 0 deletions patches/chrome-browser-download-download_target_determiner.cc.patch
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
diff --git a/chrome/browser/download/download_target_determiner.cc b/chrome/browser/download/download_target_determiner.cc
index 6e2ece915f5b00068b804607d24a0eb39bce8ffd..19a3ed5111d24613941f5c5505694cedabe42884 100644
--- a/chrome/browser/download/download_target_determiner.cc
+++ b/chrome/browser/download/download_target_determiner.cc
@@ -1253,6 +1253,7 @@ DownloadFileType::DangerLevel DownloadTargetDeterminer::GetDangerLevel(
// contains malware.
if (HasPromptedForPath() ||
confirmation_reason_ != DownloadConfirmationReason::NONE ||
+ BRAVE_DOWNLOAD_TARGET_DETERMINER_GET_DANGER_LEVEL
!download_->GetForcedFilePath().empty())
return DownloadFileType::NOT_DANGEROUS;