Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix spacing in "On Exit" tab in Clear browsing data modal #18521

Merged
merged 1 commit into from
May 18, 2023
Merged

Fix spacing in "On Exit" tab in Clear browsing data modal #18521

merged 1 commit into from
May 18, 2023

Conversation

emerick
Copy link
Contributor

@emerick emerick commented May 17, 2023

Resolves brave/brave-browser#30394

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@emerick
Fix spacing in "On Exit" tab in Clear browsing data modal
846a1ef 
Chromium change:

https://source.chromium.org/chromium/chromium/src/+/9c9fb19befc6b3417df2ccd033cf7bb3774d1d59

commit 9c9fb19befc6b3417df2ccd033cf7bb3774d1d59
Author: dpapad <dpapad@chromium.org>
Date:   Wed Apr 19 15:28:38 2023 +0000

    Settings: Remove more CSS variables from settings_vars.css.

    Replacing
     1) --settings-row-min-height with --cr-section-min-height
     2) --settings-row-two-line-min-height with
        --cr-section-two-line-min-height

    The settings variables seem unnecessary since they almost always mirror
    the value of the WebUI-wide ones.

    Bug: 1431477
@emerick emerick requested review from petemill and mkarolin May 17, 2023 22:47
@emerick emerick self-assigned this May 17, 2023
mkarolin
mkarolin approved these changes May 17, 2023
View reviewed changes
Copy link
Collaborator

@mkarolin mkarolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@emerick emerick merged commit 75f270a into master May 18, 2023
@emerick emerick deleted the cr114-followup-fix-clear-on-exit-spacing branch May 18, 2023 11:10
@emerick emerick added this to the 1.53.x - Nightly milestone May 18, 2023
@emerick emerick mentioned this pull request May 18, 2023
Merged
25 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkarolin mkarolin mkarolin approved these changes

@petemill petemill Awaiting requested review from petemill

Assignees

@emerick emerick

Labels
None yet
Projects
None yet
Milestone
1.56.x - Release
Development

Successfully merging this pull request may close these issues.

Spacing issue in on exit tab in Clear browsing data modal
2 participants
@emerick @mkarolin