Fix issue with public keys when redeeming tokens #1907
Conversation
| payment_credential.SetKey("credential", base::Value(std::move(credential))); | ||
|
|
||
| payment_credential.SetKey("publicKey", base::Value(wallet_info.public_key)); | ||
| payment_credential.SetKey("publicKey", base::Value(token_info.public_key)); |
There was a problem hiding this comment.
I'm trying to understand if the current behavior (before this patch) is a privacy issue; probably not because at this stage in redemption, the server has to see the wallet public key anyway so it can do the payment?
If the wallet public key were accidentally sent in earlier stages, that would be a privacy problem since it's a persistent identifier.
There was a problem hiding this comment.
@diracdeltas apologies I did not tag you earlier as got pulled onto another issue. The wallet public key was sent. Should we arrange a call with Jimmy?
There was a problem hiding this comment.
@diracdeltas: @amirsaber is going to fix the database once the fix has gone live
There was a problem hiding this comment.
No worries, I would just like to understand the scope of the bug. If the wallet public key was sent in Step 1 of https://docs.google.com/document/d/1gqe_RISTHu3VxfzpMKds__X73yO3aIgdeB5fBvp8da0/edit#heading=h.2hb43kpd1ag3, then there would be a privacy issue I think. If it was sent in Step 4, there would be no problem.
There was a problem hiding this comment.
If it was sent in Step 1, then all records of those requests which include the wallet address should be deleted. We should also think about what to do for clients which stay on the unfixed version (and thus will keep sending their wallet address for a while).
There was a problem hiding this comment.
@diracdeltas I can confirm it was sent in step 4. With regards to clients who stay on the unfixed version which we plan to patch before it goes to beta, Amir and Jimmy have a plan in place.
fixes brave/brave-browser#3655
Submitter Checklist:
npm test brave_unit_tests && npm test brave_browser_tests) onnpm run lint)git rebase master(if needed).git rebase -ito squash commits (if needed).Test Plan:
Confirm that viewed Ads are cashed out on Ads Serve. You can pass the command-line argument
--rewards=debug=trueto change the redemption period from ~7 days to ~25 minutes, once your ad views have been redeemed @jimmy @michael.mclaughlin are able to confirm the payments were credited to the users rewardsReviewer Checklist: