Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow WebSerial API to be enabled via brave://flags. #19252

Merged
merged 3 commits into from
Jul 17, 2023

Conversation

goodov
Copy link
Member

@goodov goodov commented Jul 12, 2023

We have a lot of requests to allow WebSerial API to be usable at least somehow, otherwise people had to use other browsers.

This PR makes WebSerial API accessible via manual enabling on brave://flags.

Resolves brave/brave-browser#24404

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@goodov goodov requested review from pes10k and fmarier July 12, 2023 13:41
@github-actions github-actions bot added CI/run-network-audit Run network-audit CI/run-upstream-tests Run upstream unit and browser tests on Linux and Windows (otherwise only on Linux) labels Jul 12, 2023
@pes10k
Copy link
Contributor

pes10k commented Jul 12, 2023

Before merging this, we need to audit these APIs more carefully, and make sure they aren't including privacy-harming values (the way we found serial numbers included in WebUSB).

@goodov if you can do so that sounds good. If you'd like me to audit the APIs though, feel free create a seperate issue(s) and assign them to me, and i'll be happy to do so ASAP

@goodov goodov changed the title Allow WebBluetooth and WebSerial APIs to be enabled via brave://flags. Allow WebSerial API to be enabled via brave://flags. Jul 13, 2023
@goodov
Copy link
Member Author

goodov commented Jul 13, 2023

Updated PR to only include WebSerial API.

@goodov goodov marked this pull request as ready for review July 13, 2023 09:34
@goodov goodov requested a review from a team as a code owner July 13, 2023 09:34
Copy link
Member

@fmarier fmarier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be good if we could hide Web Serial from the settings UI when the flag is off: brave/brave-browser#18417

browser/about_flags.cc Outdated Show resolved Hide resolved
@goodov goodov requested a review from iefremov July 14, 2023 05:13
@mmiscool
Copy link

I would really love to see this change as it would allow me to actually replace chrome for serious work.

Copy link
Collaborator

@mkarolin mkarolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@goodov goodov merged commit f06d2e8 into master Jul 17, 2023
@goodov goodov deleted the issues/15637-about-flags branch July 17, 2023 14:29
@github-actions github-actions bot added the CI/storybook-url Deploy storybook and provide a unique URL for each build label Jul 17, 2023
@github-actions github-actions bot added this to the 1.58.x - Nightly milestone Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/run-network-audit Run network-audit CI/run-upstream-tests Run upstream unit and browser tests on Linux and Windows (otherwise only on Linux) CI/storybook-url Deploy storybook and provide a unique URL for each build
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Put webserial functionality behind a flag
5 participants