-
Notifications
You must be signed in to change notification settings - Fork 883
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow WebSerial API to be enabled via brave://flags. #19252
Conversation
Before merging this, we need to audit these APIs more carefully, and make sure they aren't including privacy-harming values (the way we found serial numbers included in WebUSB). @goodov if you can do so that sounds good. If you'd like me to audit the APIs though, feel free create a seperate issue(s) and assign them to me, and i'll be happy to do so ASAP |
44ed3af
to
bb0f54e
Compare
Updated PR to only include WebSerial API. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be good if we could hide Web Serial from the settings UI when the flag is off: brave/brave-browser#18417
I would really love to see this change as it would allow me to actually replace chrome for serious work. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
We have a lot of requests to allow WebSerial API to be usable at least somehow, otherwise people had to use other browsers.
This PR makes WebSerial API accessible via manual enabling on
brave://flags
.Resolves brave/brave-browser#24404
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
wikinpm run lint
,npm run presubmit
wiki,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan: