Accumulated ads and earnings disappearing after upgrade #1952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emerick
reviewed
Mar 14, 2019
| @@ -64,20 +64,23 @@ bool UnblindedTokens::SetTokensFromList(const base::Value& list) { | |||
| } else { | |||
| base::DictionaryValue* dictionary; | |||
| if (!value.GetAsDictionary(&dictionary)) { | |||
| return false; | |||
| DCHECK(false) << "Unblinde token should be a dictionary"; | |||
| @@ -302,43 +311,83 @@ bool ConfirmationsImpl::GetTransactionHistoryFromDictionary( | |||
| for (auto& transaction_value : transactions_list_value) { | |||
| base::DictionaryValue* transaction_dictionary; | |||
| if (!transaction_value.GetAsDictionary(&transaction_dictionary)) { | |||
| return false; | |||
| DCHECK(false) << "Transaction should be a dictionary"; | |||
| continue; | |||
There was a problem hiding this comment.
It's OK to continue here when the data isn't as expected?
There was a problem hiding this comment.
it is as if transaction gets into a bad state, we should still keep good transactions
There was a problem hiding this comment.
Also this way bad transactions are still persisted in the state to help diagnose issues
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes brave/brave-browser#3716
Submitter Checklist:
npm test brave_unit_tests && npm test brave_browser_tests) onnpm run lint)git rebase master(if needed).git rebase -ito squash commits (if needed).Test Plan:
Confirm after upgrading from 0.63.4 to latest 0.63.x ad views are not lost.
Reviewer Checklist: