Modified output name for linux build to 'brave' #2
+19
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bridiver
reviewed
Dec 8, 2017
| output_name = "initialexe/chrome" | ||
| } else { | ||
| - output_name = "chrome" | ||
| + output_name = "brave" |
There was a problem hiding this comment.
I think we also need to update chrome_binary = "$root_out_dir/chrome" in linux_symbols or official builds with symbols stripped will fail
There was a problem hiding this comment.
Yes, while trying to build with npm run build -- --debug_build=true --official_build=true I had an error
ERROR Input to target not generated by a dependency.
The file:
//out/Release/chrome
is listed as an input or source for the target:
//chrome:linux_symbols
but no targets in the build generate that file.
fixed in in a new branch and new PR, https://github.com/brave/antimuon/tree/build-linux-output-name2, #3, because I could not build it in original PR branch build-linux-output-name.
bbondy
added a commit
that referenced
this pull request
Feb 18, 2019
suppress React rAF warning while testing
18 tasks
ryanml
added a commit
that referenced
this pull request
Apr 3, 2019
Fixes scrollbar for unverified notice on MacOS [0.64] (#2)
mkarolin
added a commit
that referenced
this pull request
Sep 25, 2019
Chromium changes: https://chromium.googlesource.com/chromium/src/+/26e73cfd90affbf1bdf3efbe80bf2903b0e866ae commit 26e73cfd90affbf1bdf3efbe80bf2903b0e866ae Author: Yutaka Hirano <yhirano@chromium.org> Date: Tue Aug 6 02:38:13 2019 +0000 Stop giving WebSocketClient to WebSocket creation function Instead, give it as an argument of mojom.WebSocketHandshakeClient.OnConnectionEstablished. This is a follow up CL for https://chromium-review.googlesource.com/c/chromium/src/+/1728917. Passing the mojo::InterfaceRequest<WebSocketClient> at OnConnectionEstablished is less error prone because 1) It is unable to bind the implementation before that, and 2) It is now clear that we should detect connection errors on |handshake_client| until the connection is established, and |client| after that. Bug: 989406, 967524 https://chromium.googlesource.com/chromium/src/+/1007403a797957b8af46e962cdfc1f6f671954a4 commit 1007403a797957b8af46e962cdfc1f6f671954a4 Author: Yoichi Osato <yoichio@chromium.org> Date: Thu Aug 8 13:11:57 2019 +0000 [WebSocket] Use Datapipe to transfer DataFrame buffer instead of ReadOnlyBuffer This CL introduces mojo DataPipe instead of ReadOnlyBuffer. With DataPipe, we can reduce memory copy and optimize quota control. Unfortunately, this CL makes performance slower: ToT: 147 MB/s Patch: 128 MB/s That's because this CL replaces minimize part and we will do the optimization later on. If the optimization doesn't go over the original score before M78 (will be branch cut on Sep 5th), we will revert this change. Bug: 865001 https://chromium.googlesource.com/chromium/src/+/fcaa2a2c441e28a5cb95cc90946712efb0ce085f commit fcaa2a2c441e28a5cb95cc90946712efb0ce085f Author: Yoichi Osato <yoichio@chromium.org> Date: Wed Aug 28 08:22:36 2019 +0000 [WebSocket] Remove manual quota control for receiving. Because we're using mojo data pipe, which has own quota control, to transfer received data, we don't have manual one, or mojom::WebSocket.AddReceiveFlowControlQuota(). This CL does a sort of work removing the function. mojom::WebSocket.AddReceiveFlowControlQuota(quota) did 5 tasks: browser side(mainly on WebSocketChannel) 1. Trigger the first ReadFrame if renderer gets not throttled. For #1, this patch moves the trigger to mojo WebSocket.StartReceiving. 2. Trigger next ReadFrame if there is enough quota. 3. Send pending dataframes based on added quota. This patch moves task #2 and #3 to websocket.cc and datapipe itself. 4. Dropchannel if all pending frames are received by renderer when closed. Because we can care #4 w/o renderer ping back, this patch move RespondToClosingHandshake()to WebSocketChannel::ReadFrames(). renderer side(mainly on WebSocketChannelImpl) 5. Ping browser that backpressure is turned off. For task #5, this patch changes not to call the mojo but throttle datapipe reading with WebSocketHandleImpl::ConsumePendingDataFrames(). receive-arraybuffer-1MBx100.htmll?iteration=100 measurement on local build: ToT: 144 MB/s (stdev: 4.56 MB/s) Patch: 208 MB/s (stdev: 6.15 MB/s) (+44% to ToT, +41% to ReadOnlyBuffer) ReadOnlyBuffer: 147 MB/s https://chromium.googlesource.com/chromium/src/+/a461132e64f53f45997aaa4222e05cdf5d10ea56 commit a461132e64f53f45997aaa4222e05cdf5d10ea56 Author: Julie Jeongeun Kim <jkim@igalia.com> Date: Fri Aug 30 04:13:36 2019 +0000 Reland "Convert WebSocket to new Mojo types" This is a reland of 06a7200b370f38f39c97a4810d0931ab5596014e It updates WebSocketChannelImplTest::EstablishConnection with new Mojo types without InterfacePtr and MakeRequest. TBR=jam@chromium.org Original change's description: > Convert WebSocket to new Mojo types > > This CL converts WebSocketPtr, to new Mojo types and > updates OnConnectionEstablished from websocket.mojom. > > Bug: 955171, 978694 > Change-Id: I82416b209e2380241b64ebd3d829dd8bde5247c7 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773016 > Commit-Queue: Julie Kim <jkim@igalia.com> > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Reviewed-by: Sam McNally <sammc@chromium.org> > Reviewed-by: Yutaka Hirano <yhirano@chromium.org> > Reviewed-by: Ken Rockot <rockot@google.com> > Cr-Commit-Position: refs/heads/master@{#691574} Bug: 955171, 978694
cdesouza-chromium
added a commit
that referenced
this pull request
Mar 18, 2024
These specific flags were being disabled by default, however the code they were guarding is now deleted. Chromium change: https://chromium.googlesource.com/chromium/src/+/f8eb4d46d0bc268eba98dbfe23b1abf26ccb07d7 commit f8eb4d46d0bc268eba98dbfe23b1abf26ccb07d7 Author: Rainhard Findling <rainhard@chromium.org> Date: Tue Mar 5 08:20:43 2024 +0000 Reland #2 "Privacy Guide: remove search suggestions and preload cards" This is attempt #2 to reland this cleanup. Earlier attempts: commit 1faae6bd62538e3f685c7143d003a05dd5fbfffa and commit 01170d74d06655cd7244026dc0689542702c9bc2. This is created as a revert-of-a-revert as Gerrit currently doesn't allow to create a reland with merge conflicts (crbug.com/41395970). The position of the cookie step that is shown in the PG flow in the 3PCD-disabled codepath has been updated in the integration test (see delta of patchset 1>2) which should (hopefully) make it pass also on waterfall bots. The reason why this wasn't caught in the last 2 CLs seems to stem from how 3PCD is tested in privacy_guide_integration_test.ts: privacy_guide_integration_test.ts does not force the 3PCD state to test both possible codepaths, but instead relies on the fieldtrial_testing_configs to run both possible 3PCD code paths [1]. Contrary to our earlier understanding it seems that on local builds and on CQ bots, the fieldtrial_testing_configs does not actually run both possible 3PCD code paths, but only the 3PCD-enabled code path. As the cookie step is shown in PG only in the 3PCD-disabled code path, as a result of that code path seemingly not being tested in local builds and in CQ bots, the incorrect position of the cookie step in the integration test was not caught in the last 2 CLs. [1] https://chromium-review.googlesource.com/c/chromium/src/+/5014485/comment/6a847c98_64081fc3/ Original change's description: > Privacy Guide: clean up search suggestions and preload cards > > The product decision has been made that the "improve search > suggestions" and "preload" cards in privacy guide won't launch. This > CL removes those cards from privacy guide. > > Bug: 40184479 > Change-Id: I747c2c693ca624d769290c2351d02d4c0913bdab > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5279392 > Reviewed-by: Theodore Olsauskas-Warren <sauski@google.com> > Commit-Queue: John Lee <johntlee@chromium.org> > Reviewed-by: Side YILMAZ <sideyilmaz@chromium.org> > Reviewed-by: John Lee <johntlee@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1264176} Bug: 40184479
cdesouza-chromium
added a commit
that referenced
this pull request
Mar 27, 2024
These specific flags were being disabled by default, however the code they were guarding is now deleted. Chromium change: https://chromium.googlesource.com/chromium/src/+/f8eb4d46d0bc268eba98dbfe23b1abf26ccb07d7 commit f8eb4d46d0bc268eba98dbfe23b1abf26ccb07d7 Author: Rainhard Findling <rainhard@chromium.org> Date: Tue Mar 5 08:20:43 2024 +0000 Reland #2 "Privacy Guide: remove search suggestions and preload cards" This is attempt #2 to reland this cleanup. Earlier attempts: commit 1faae6bd62538e3f685c7143d003a05dd5fbfffa and commit 01170d74d06655cd7244026dc0689542702c9bc2. This is created as a revert-of-a-revert as Gerrit currently doesn't allow to create a reland with merge conflicts (crbug.com/41395970). The position of the cookie step that is shown in the PG flow in the 3PCD-disabled codepath has been updated in the integration test (see delta of patchset 1>2) which should (hopefully) make it pass also on waterfall bots. The reason why this wasn't caught in the last 2 CLs seems to stem from how 3PCD is tested in privacy_guide_integration_test.ts: privacy_guide_integration_test.ts does not force the 3PCD state to test both possible codepaths, but instead relies on the fieldtrial_testing_configs to run both possible 3PCD code paths [1]. Contrary to our earlier understanding it seems that on local builds and on CQ bots, the fieldtrial_testing_configs does not actually run both possible 3PCD code paths, but only the 3PCD-enabled code path. As the cookie step is shown in PG only in the 3PCD-disabled code path, as a result of that code path seemingly not being tested in local builds and in CQ bots, the incorrect position of the cookie step in the integration test was not caught in the last 2 CLs. [1] https://chromium-review.googlesource.com/c/chromium/src/+/5014485/comment/6a847c98_64081fc3/ Original change's description: > Privacy Guide: clean up search suggestions and preload cards > > The product decision has been made that the "improve search > suggestions" and "preload" cards in privacy guide won't launch. This > CL removes those cards from privacy guide. > > Bug: 40184479 > Change-Id: I747c2c693ca624d769290c2351d02d4c0913bdab > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5279392 > Reviewed-by: Theodore Olsauskas-Warren <sauski@google.com> > Commit-Queue: John Lee <johntlee@chromium.org> > Reviewed-by: Side YILMAZ <sideyilmaz@chromium.org> > Reviewed-by: John Lee <johntlee@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1264176} Bug: 40184479
cdesouza-chromium
added a commit
that referenced
this pull request
Mar 28, 2024
These specific flags were being disabled by default, however the code they were guarding is now deleted. Chromium change: https://chromium.googlesource.com/chromium/src/+/f8eb4d46d0bc268eba98dbfe23b1abf26ccb07d7 commit f8eb4d46d0bc268eba98dbfe23b1abf26ccb07d7 Author: Rainhard Findling <rainhard@chromium.org> Date: Tue Mar 5 08:20:43 2024 +0000 Reland #2 "Privacy Guide: remove search suggestions and preload cards" This is attempt #2 to reland this cleanup. Earlier attempts: commit 1faae6bd62538e3f685c7143d003a05dd5fbfffa and commit 01170d74d06655cd7244026dc0689542702c9bc2. This is created as a revert-of-a-revert as Gerrit currently doesn't allow to create a reland with merge conflicts (crbug.com/41395970). The position of the cookie step that is shown in the PG flow in the 3PCD-disabled codepath has been updated in the integration test (see delta of patchset 1>2) which should (hopefully) make it pass also on waterfall bots. The reason why this wasn't caught in the last 2 CLs seems to stem from how 3PCD is tested in privacy_guide_integration_test.ts: privacy_guide_integration_test.ts does not force the 3PCD state to test both possible codepaths, but instead relies on the fieldtrial_testing_configs to run both possible 3PCD code paths [1]. Contrary to our earlier understanding it seems that on local builds and on CQ bots, the fieldtrial_testing_configs does not actually run both possible 3PCD code paths, but only the 3PCD-enabled code path. As the cookie step is shown in PG only in the 3PCD-disabled code path, as a result of that code path seemingly not being tested in local builds and in CQ bots, the incorrect position of the cookie step in the integration test was not caught in the last 2 CLs. [1] https://chromium-review.googlesource.com/c/chromium/src/+/5014485/comment/6a847c98_64081fc3/ Original change's description: > Privacy Guide: clean up search suggestions and preload cards > > The product decision has been made that the "improve search > suggestions" and "preload" cards in privacy guide won't launch. This > CL removes those cards from privacy guide. > > Bug: 40184479 > Change-Id: I747c2c693ca624d769290c2351d02d4c0913bdab > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5279392 > Reviewed-by: Theodore Olsauskas-Warren <sauski@google.com> > Commit-Queue: John Lee <johntlee@chromium.org> > Reviewed-by: Side YILMAZ <sideyilmaz@chromium.org> > Reviewed-by: John Lee <johntlee@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1264176} Bug: 40184479
cdesouza-chromium
added a commit
that referenced
this pull request
Apr 3, 2024
These specific flags were being disabled by default, however the code they were guarding is now deleted. Chromium change: https://chromium.googlesource.com/chromium/src/+/f8eb4d46d0bc268eba98dbfe23b1abf26ccb07d7 commit f8eb4d46d0bc268eba98dbfe23b1abf26ccb07d7 Author: Rainhard Findling <rainhard@chromium.org> Date: Tue Mar 5 08:20:43 2024 +0000 Reland #2 "Privacy Guide: remove search suggestions and preload cards" This is attempt #2 to reland this cleanup. Earlier attempts: commit 1faae6bd62538e3f685c7143d003a05dd5fbfffa and commit 01170d74d06655cd7244026dc0689542702c9bc2. This is created as a revert-of-a-revert as Gerrit currently doesn't allow to create a reland with merge conflicts (crbug.com/41395970). The position of the cookie step that is shown in the PG flow in the 3PCD-disabled codepath has been updated in the integration test (see delta of patchset 1>2) which should (hopefully) make it pass also on waterfall bots. The reason why this wasn't caught in the last 2 CLs seems to stem from how 3PCD is tested in privacy_guide_integration_test.ts: privacy_guide_integration_test.ts does not force the 3PCD state to test both possible codepaths, but instead relies on the fieldtrial_testing_configs to run both possible 3PCD code paths [1]. Contrary to our earlier understanding it seems that on local builds and on CQ bots, the fieldtrial_testing_configs does not actually run both possible 3PCD code paths, but only the 3PCD-enabled code path. As the cookie step is shown in PG only in the 3PCD-disabled code path, as a result of that code path seemingly not being tested in local builds and in CQ bots, the incorrect position of the cookie step in the integration test was not caught in the last 2 CLs. [1] https://chromium-review.googlesource.com/c/chromium/src/+/5014485/comment/6a847c98_64081fc3/ Original change's description: > Privacy Guide: clean up search suggestions and preload cards > > The product decision has been made that the "improve search > suggestions" and "preload" cards in privacy guide won't launch. This > CL removes those cards from privacy guide. > > Bug: 40184479 > Change-Id: I747c2c693ca624d769290c2351d02d4c0913bdab > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5279392 > Reviewed-by: Theodore Olsauskas-Warren <sauski@google.com> > Commit-Queue: John Lee <johntlee@chromium.org> > Reviewed-by: Side YILMAZ <sideyilmaz@chromium.org> > Reviewed-by: John Lee <johntlee@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1264176} Bug: 40184479
cdesouza-chromium
added a commit
that referenced
this pull request
Apr 4, 2024
These specific flags were being disabled by default, however the code they were guarding is now deleted. Chromium change: https://chromium.googlesource.com/chromium/src/+/f8eb4d46d0bc268eba98dbfe23b1abf26ccb07d7 commit f8eb4d46d0bc268eba98dbfe23b1abf26ccb07d7 Author: Rainhard Findling <rainhard@chromium.org> Date: Tue Mar 5 08:20:43 2024 +0000 Reland #2 "Privacy Guide: remove search suggestions and preload cards" This is attempt #2 to reland this cleanup. Earlier attempts: commit 1faae6bd62538e3f685c7143d003a05dd5fbfffa and commit 01170d74d06655cd7244026dc0689542702c9bc2. This is created as a revert-of-a-revert as Gerrit currently doesn't allow to create a reland with merge conflicts (crbug.com/41395970). The position of the cookie step that is shown in the PG flow in the 3PCD-disabled codepath has been updated in the integration test (see delta of patchset 1>2) which should (hopefully) make it pass also on waterfall bots. The reason why this wasn't caught in the last 2 CLs seems to stem from how 3PCD is tested in privacy_guide_integration_test.ts: privacy_guide_integration_test.ts does not force the 3PCD state to test both possible codepaths, but instead relies on the fieldtrial_testing_configs to run both possible 3PCD code paths [1]. Contrary to our earlier understanding it seems that on local builds and on CQ bots, the fieldtrial_testing_configs does not actually run both possible 3PCD code paths, but only the 3PCD-enabled code path. As the cookie step is shown in PG only in the 3PCD-disabled code path, as a result of that code path seemingly not being tested in local builds and in CQ bots, the incorrect position of the cookie step in the integration test was not caught in the last 2 CLs. [1] https://chromium-review.googlesource.com/c/chromium/src/+/5014485/comment/6a847c98_64081fc3/ Original change's description: > Privacy Guide: clean up search suggestions and preload cards > > The product decision has been made that the "improve search > suggestions" and "preload" cards in privacy guide won't launch. This > CL removes those cards from privacy guide. > > Bug: 40184479 > Change-Id: I747c2c693ca624d769290c2351d02d4c0913bdab > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5279392 > Reviewed-by: Theodore Olsauskas-Warren <sauski@google.com> > Commit-Queue: John Lee <johntlee@chromium.org> > Reviewed-by: Side YILMAZ <sideyilmaz@chromium.org> > Reviewed-by: John Lee <johntlee@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1264176} Bug: 40184479
24 tasks
mkarolin
pushed a commit
that referenced
this pull request
Apr 9, 2024
These specific flags were being disabled by default, however the code they were guarding is now deleted. Chromium change: https://chromium.googlesource.com/chromium/src/+/f8eb4d46d0bc268eba98dbfe23b1abf26ccb07d7 commit f8eb4d46d0bc268eba98dbfe23b1abf26ccb07d7 Author: Rainhard Findling <rainhard@chromium.org> Date: Tue Mar 5 08:20:43 2024 +0000 Reland #2 "Privacy Guide: remove search suggestions and preload cards" This is attempt #2 to reland this cleanup. Earlier attempts: commit 1faae6bd62538e3f685c7143d003a05dd5fbfffa and commit 01170d74d06655cd7244026dc0689542702c9bc2. This is created as a revert-of-a-revert as Gerrit currently doesn't allow to create a reland with merge conflicts (crbug.com/41395970). The position of the cookie step that is shown in the PG flow in the 3PCD-disabled codepath has been updated in the integration test (see delta of patchset 1>2) which should (hopefully) make it pass also on waterfall bots. The reason why this wasn't caught in the last 2 CLs seems to stem from how 3PCD is tested in privacy_guide_integration_test.ts: privacy_guide_integration_test.ts does not force the 3PCD state to test both possible codepaths, but instead relies on the fieldtrial_testing_configs to run both possible 3PCD code paths [1]. Contrary to our earlier understanding it seems that on local builds and on CQ bots, the fieldtrial_testing_configs does not actually run both possible 3PCD code paths, but only the 3PCD-enabled code path. As the cookie step is shown in PG only in the 3PCD-disabled code path, as a result of that code path seemingly not being tested in local builds and in CQ bots, the incorrect position of the cookie step in the integration test was not caught in the last 2 CLs. [1] https://chromium-review.googlesource.com/c/chromium/src/+/5014485/comment/6a847c98_64081fc3/ Original change's description: > Privacy Guide: clean up search suggestions and preload cards > > The product decision has been made that the "improve search > suggestions" and "preload" cards in privacy guide won't launch. This > CL removes those cards from privacy guide. > > Bug: 40184479 > Change-Id: I747c2c693ca624d769290c2351d02d4c0913bdab > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5279392 > Reviewed-by: Theodore Olsauskas-Warren <sauski@google.com> > Commit-Queue: John Lee <johntlee@chromium.org> > Reviewed-by: Side YILMAZ <sideyilmaz@chromium.org> > Reviewed-by: John Lee <johntlee@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1264176} Bug: 40184479
aseren
added a commit
that referenced
this pull request
Apr 10, 2024
24 tasks
24 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified output name for linux build from chrome to 'brave'