Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix release mode brave_unit_tests crash on Windows #201

Merged
merged 1 commit into from
Jun 28, 2018

Commits on Jun 28, 2018

  1. Fix release mode brave_unit_tests crash on Windows

    This is regression of #158.
    During the initialization of unit test, channel info is accessed.
    However, |g_module_details| isn't initialized in test.
    Before the above PR, channel was always Channel::UNKNOWN.
    So, channel info can be fetched without accessing |g_module_details|.
    After the above PR, channel info is fetched via |g_module_details| in
    release mode. So crash is happened because |g_module_details| is
    nullptr.
    Fixed by initializing install details explicitly.
    simonhong committed Jun 28, 2018
    Configuration menu
    Copy the full SHA
    8abb3a4 View commit details
    Browse the repository at this point in the history