Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabling Ads Panel for disallowed regions [0.63] #2020

Merged
merged 1 commit into from
Mar 21, 2019

Conversation

ryanml
Copy link
Contributor

@ryanml ryanml commented Mar 21, 2019

Issue: brave/brave-browser#2562
Original PR: #1941
UI on .63: brave/brave-ui@004b5a4

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Verified that these changes build without errors on
    • Windows
    • macOS
    • Linux
  • Verified that these changes pass automated tests (npm test brave_unit_tests && npm test brave_browser_tests) on
    • Windows
    • macOS
    • Linux
  • Verified that all lint errors/warnings are resolved (npm run lint)
  • Ran git rebase master (if needed).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.
  • Add appropriate QA labels (QA/Yes or QA/No) to include the closed issue in milestone

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

Disabling Ads Panel for disallowed regions
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift to 0.63.x approved after deliberating with @rebron and @srirambv. Please ensure that all needed labels are added and that all associated issues are moved into the correct milestone.

Please double check and make sure that the jenkins failure isn't due to this specific PR.

@ryanml ryanml merged commit c07cdb2 into 0.63.x Mar 21, 2019
@ryanml ryanml deleted the 0.63.x-ads-supported branch March 21, 2019 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants