Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert Chromium 74 from master #2079

Closed
wants to merge 5 commits into from
Closed

Revert Chromium 74 from master #2079

wants to merge 5 commits into from

Conversation

bsclifton
Copy link
Member

@bsclifton bsclifton commented Mar 26, 2019

DO NOT MERGE UNLESS CI PASSES

Related: brave/brave-browser#3896
Reverts:

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Verified that these changes build without errors on
    • Windows
    • macOS
    • Linux
  • Verified that these changes pass automated tests (npm test brave_unit_tests && npm test brave_browser_tests && npm run test-security) on
    • Windows
    • macOS
    • Linux
  • Verified that all lint errors/warnings are resolved (npm run lint)
  • Ran git rebase master (if needed).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.
  • Add appropriate QA labels (QA/Yes or QA/No) to include the closed issue in milestone

Test Plan:

  1. Go into Jenkins for this PR
  2. Verify everything passes on all platforms
  3. If anything fails, don't merge

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

@bsclifton bsclifton added this to the 0.64.x - Nightly milestone Mar 26, 2019
@bsclifton bsclifton self-assigned this Mar 26, 2019
@bsclifton bsclifton changed the title WIP - Revert c74 WIP: Revert c74 Mar 26, 2019
@bsclifton bsclifton force-pushed the revert-c74 branch 4 times, most recently from 86cba0a to f16da89 Compare March 26, 2019 21:43
@bsclifton bsclifton marked this pull request as ready for review March 27, 2019 01:27
bsclifton and others added 3 commits March 26, 2019 18:35
…ded to a queue and retried"

This reverts commit fded297.
(originally implemented with #2013)

Fixes brave/brave-browser#3898
This reverts commit 27c5932, reversing
changes made to 2a6fe67.
@bsclifton bsclifton changed the title WIP: Revert c74 Revert Chromium 74 from master Mar 27, 2019
@mihaiplesa mihaiplesa self-requested a review March 27, 2019 09:29
mihaiplesa
mihaiplesa previously approved these changes Mar 27, 2019
@jumde jumde mentioned this pull request Mar 27, 2019
19 tasks
@jumde
Copy link
Contributor

jumde commented Mar 27, 2019

This PR was split into: #2088 and #2094

Please read the Description in #2088 if you need more details. Waiting for nightlies to be built before closing this PR.

@bsclifton
Copy link
Member Author

Closing as #2088 and #2094 were merged (in addition to brave/brave-browser#3896). New Nightly version 0.64.22 is now available 😄

@bsclifton bsclifton closed this Mar 28, 2019
@bsclifton bsclifton deleted the revert-c74 branch March 28, 2019 06:45
@bsclifton bsclifton removed this from the 0.64.x - Nightly milestone Mar 28, 2019
fmarier pushed a commit that referenced this pull request Oct 29, 2019
Upgrade from Chromium 71.0.3578.31 to 71.0.3578.44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Chromium 74 update is breaking nightly build
3 participants