Branding in settings and history pages #212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yrliou
changed the title
9 tasks
bbondy
approved these changes
Jul 3, 2018
33 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix brave/brave-browser#212
Need to be merged together with brave/brave-browser#462
Note that the change in browser/resources/settings/settings_resources.grd is generated by l10nUtil.js.
And brave_page_visibility.js is copied into src/chrome/browser/resources/settings to be processed and
bundled along with other settings resources.
Please see brave/brave-browser#462 for the corresponding PR in brave-browser for above.
Hiding below items:
Tabs from other devicesin history sidebar and remove path forchrome://history/syncedTabsto remove access to the below page