Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Ads locale on Windows 0.63.x #2288

Merged
merged 5 commits into from
Apr 19, 2019
Merged

Fix Ads locale on Windows 0.63.x #2288

merged 5 commits into from
Apr 19, 2019

Conversation

tmancey
Copy link
Collaborator

@tmancey tmancey commented Apr 19, 2019

Uplift for #2285
Fixes brave/brave-browser#4172
Requires #2276

ryanml and others added 4 commits April 19, 2019 02:39
Fix Ads enabled for unsupported regions and enabled by default after 0.63.x update
Fix Shows supported region correctly for Ads on first load after upgrade.
Fix Ads enabled when joining Rewards via panel
Copy link
Collaborator

@rebron rebron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@tmancey
Copy link
Collaborator Author

tmancey commented Apr 19, 2019

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they're landing to.

@tmancey tmancey merged commit a7ec27e into 0.63.x Apr 19, 2019
@tmancey tmancey deleted the issues/4172-0.63.x branch April 19, 2019 04:34
fmarier pushed a commit that referenced this pull request Oct 29, 2019
Upgrade from Chromium 71.0.3578.53 to 71.0.3578.75
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants