Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Brave Ads has arrived!" notification should be shown on Linux after upgrade from 0.62.x - 0.65.x #2322

Merged
merged 1 commit into from
May 8, 2019
Merged

"Brave Ads has arrived!" notification should be shown on Linux after upgrade from 0.62.x - 0.65.x #2322

merged 1 commit into from
May 8, 2019

Conversation

tmancey
Copy link
Collaborator

@tmancey tmancey commented Apr 23, 2019

Uplift for #2321
Fixes brave/brave-browser#4202

@tmancey tmancey added this to the 0.65.x - Dev milestone Apr 23, 2019
@tmancey tmancey requested a review from a team April 23, 2019 20:00
@tmancey tmancey self-assigned this Apr 23, 2019
@tmancey tmancey changed the title "Brave Ads has arrived!" notification should be shown on Linux after upgrade from 0.65.x "Brave Ads has arrived!" notification should be shown on Linux after upgrade from 0.62.x - 0.65.x Apr 23, 2019
@kjozwiak
Copy link
Member

@tmancey looks like this PR is still a work in progress even though it's waiting approval. Are we waiting for 0.65.x builds so we can confirm that the fix is working correctly?

@tmancey tmancey marked this pull request as ready for review May 5, 2019 19:03
@tmancey
Copy link
Collaborator Author

tmancey commented May 5, 2019

@tmancey looks like this PR is still a work in progress even though it's waiting approval. Are we waiting for 0.65.x builds so we can confirm that the fix is working correctly?

Unblocked and ready for review as was waiting to test on nightly

bsclifton
bsclifton approved these changes May 8, 2019
View reviewed changes
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jenkins had a little trouble with this PR - I took a look and saw that all platforms were building and tests were passing. The job (each time) got caught on something (my guess environment specific) and was terminated. Uploads were put on S3, tests did run as expected and passed. Going to approve 😄

@bsclifton bsclifton merged commit 230e51a into 0.65.x May 8, 2019
@bsclifton bsclifton deleted the issues/4202-0.65.x branch May 8, 2019 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bsclifton bsclifton bsclifton approved these changes

Assignees

@tmancey tmancey

Labels
bug feature/ads
Projects
None yet
Milestone
0.65.x - Release
Development

Successfully merging this pull request may close these issues.
3 participants
@tmancey @kjozwiak @bsclifton