Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings: location bar -> address bar #2519

Merged
merged 1 commit into from
Jun 1, 2019
Merged

Conversation

petemill
Copy link
Member

Fix brave/brave-browser#4508

Submitter Checklist:

Test Plan:

Open brave://settings and verify text is as described in issue.

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@petemill petemill requested review from bsclifton and rebron May 28, 2019 17:19
@petemill petemill self-assigned this May 28, 2019
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 😄

@bsclifton bsclifton merged commit 1900bab into master Jun 1, 2019
@bsclifton bsclifton deleted the string-settings-address-bar branch June 1, 2019 07:07
@bsclifton bsclifton added this to the 0.68.x - Nightly milestone Jun 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

change label to 'address bar' instead of 'location bar'
2 participants