Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep track of tags after deserializing #2751

Merged
merged 1 commit into from
Jun 20, 2019
Merged

Keep track of tags after deserializing #2751

merged 1 commit into from
Jun 20, 2019

Conversation

bbondy
Copy link
Member

@bbondy bbondy commented Jun 20, 2019

Fix brave/brave-browser#4743

Partial uplift of a single commit from PR:
#2569

It will be fixed on master with that commit, but to fix it in 0.67.x we don't want Rust ad-block yet. So only 1 commit is cherry-picked.

Submitter Checklist:

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@bbondy bbondy added this to the 0.67.x - Dev milestone Jun 20, 2019
@bbondy bbondy requested a review from a team June 20, 2019 02:36
@bbondy bbondy self-assigned this Jun 20, 2019
@mihaiplesa mihaiplesa added CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS CI/skip-linux and removed CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS CI/skip-linux labels Jun 20, 2019
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift to 0.67.x approved. Please ensure that all the correct labels are being used and that the appropriate issue is moved into the correct milestone.

@bbondy bbondy merged commit a49bd0c into 0.67.x Jun 20, 2019
@mihaiplesa mihaiplesa deleted the tags-deserialize branch June 20, 2019 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants