Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate brave-core changes from Android Ads #2876

Closed
wants to merge 1 commit into from
Closed

Conversation

tmancey
Copy link
Collaborator

@tmancey tmancey commented Jul 6, 2019

Fixes brave/brave-browser#5160

Submitter Checklist:

Test Plan:

  • Confirm ad notifications are shown
  • Switch ads off and then back on and confirm ad notifications are still shown
  • Confirm ads are cashed-in
  • Confirm clicking an ad that it opens in a new tab
  • Confirm default/ads_service state is removed when ads are switched off
  • Confirm ad notifications are closed when switching ads off
  • Confirm ads are not shown if the network is disconnected

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@tmancey tmancey added this to the 0.69.x - Nightly milestone Jul 6, 2019
@tmancey tmancey requested a review from bsclifton as a code owner July 6, 2019 02:16
@tmancey tmancey self-assigned this Jul 6, 2019
@tmancey tmancey force-pushed the issues/5160 branch 3 times, most recently from 72ac096 to b25ddbc Compare July 6, 2019 02:34
@tmancey tmancey changed the title Migrate brave-core changes from Android Ads [WIPMigrate brave-core changes from Android Ads Jul 6, 2019
@tmancey tmancey changed the title [WIPMigrate brave-core changes from Android Ads [WIP] Migrate brave-core changes from Android Ads Jul 6, 2019
@tmancey tmancey force-pushed the issues/5160 branch 12 times, most recently from 82182eb to d7bf680 Compare July 10, 2019 06:37
@tmancey tmancey force-pushed the issues/5160 branch 3 times, most recently from 245a33d to 24081cd Compare July 16, 2019 15:59
@tmancey tmancey force-pushed the issues/5160 branch 9 times, most recently from a366f50 to df362bd Compare July 17, 2019 00:45
@tmancey tmancey closed this Jul 17, 2019
@tmancey tmancey deleted the issues/5160 branch July 17, 2019 23:41
@tmancey tmancey removed this from the 0.69.x - Nightly milestone Jul 17, 2019
@tmancey tmancey changed the title [WIP] Migrate brave-core changes from Android Ads Migrate brave-core changes from Android Ads Jul 18, 2019
@tmancey
Copy link
Collaborator Author

tmancey commented Jul 18, 2019

Superseded by #2947

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate brave-core changes from Android Ads
1 participant