Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restrict target list that can depend on brave/components/omnibox/browser #308

Merged
merged 1 commit into from
Aug 10, 2018
Merged

Restrict target list that can depend on brave/components/omnibox/browser #308

merged 1 commit into from
Aug 10, 2018

Conversation

simonhong
Copy link
Member

@simonhong simonhong commented Aug 2, 2018 •
edited
Loading

By using visibility gn variable, explicitly restrict target list
that can depend on //brave/components/omnibox/browser.

Issue brave/brave-browser#671

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions

@simonhong
Restrict target list that can depend on brave/components/omnibox/browser
19cb177 
By using visibility gn variable, explicitly restrict target list
that can depend on //brave/components/omnibox/browser.
@simonhong simonhong self-assigned this Aug 2, 2018
@simonhong simonhong requested a review from bbondy August 2, 2018 06:00
@bbondy bbondy merged commit aa0838b into master Aug 10, 2018
@simonhong simonhong deleted the dependency_restriction branch August 19, 2018 23:22
petemill added a commit that referenced this pull request Dec 11, 2018
@petemill
Update to latest brave-ui master
f1413cf 
Changes:
```
*   cee363d - (44 minutes ago) Merge pull request #314 from brave/revert-sync-master — Pete Miller (HEAD -> master, origin/master, origin/HEAD)
|\
| * 0ca4b73 - (56 minutes ago) Revert "sync v2" — Cezar Augusto
| * a479cea - (56 minutes ago) Revert "Merge pull request #308 from brave/sync_img" — Cezar Augusto
|/
*   dd46eab - (19 hours ago) Merge pull request #247 from brave/c71-clock-period — Pete Miller
|\
| * 20d2a61 - (7 weeks ago) Fix NTP clock for c71 — petemill (origin/c71-clock-period, c71-clock-period)
* |   69a3399 - (19 hours ago) Merge pull request #305 from ryanml/android-rewards-title-fix — Pete Miller
|\ \
| |/
|/|
| * d92ce8f - (7 days ago) Fixing rewards toggle for long translations — ryanml (ryanml/android-rewards-title-fix, android-rewards-title-fix)
|/
* 4692dfd - (25 hours ago) readme typos — Ross Moody
*   ca3e285 - (29 hours ago) Merge pull request #312 from emerick/rewards-backup-wallet-notification — Nejc Zdovc
|\
| * 4dda1bc - (4 days ago) Add support for backupWallet notification — Emerick Rogul
* | 0a5f56e - (4 days ago) Emoji Life — Ross Moody
* | be16816 - (4 days ago) Readme formatting — Ross Moody
* | 35b166d - (4 days ago) Brave UI Logo — Ross Moody
* |   fddeb8a - (4 days ago) Merge pull request #311 from brave/now-deploy-static — Cezar Augusto
|\ \
| * | 6685301 - (5 days ago) Use new static deploy config for now instead of docker — petemill (origin/now-deploy-static, now-deploy-static)
* | | eb49e8b - (4 days ago) remove list from README file — Cezar Augusto
* | | 59eae8d - (4 days ago) remove outdated docs — Cezar Augusto
* | | f04fecc - (4 days ago) do not count first letter if space in textareaclipboard — Cezar Augusto
| |/
|/|
* |   7ea9178 - (5 days ago) Merge pull request #308 from brave/sync_img — Cezar Augusto
|\ \
| * | 470233f - (6 days ago) make sync images exportable — Cezar Augusto
| |/
* |   aa520cf - (5 days ago) Merge pull request #309 from brave/welcome_img — Pete Miller
|\ \
| * | 870d3ba - (6 days ago) animation dial in — Ross Moody (origin/welcome_img, welcome_img)
| * | 1c2525b - (6 days ago) make welcome page images exportable — Cezar Augusto
| |/
* |   96ccb12 - (6 days ago) Merge pull request #307 from kirkins/patch-1 — Ryan Lanese
|\ \
| * | f98a665 - (6 days ago) small typo — Philip Kirkbride
* | | f3c38e1 - (6 days ago) v0.36.0 — ryanml (tag: v0.36.0)
|/ /
* |   46b3501 - (6 days ago) Merge pull request #304 from ryanml/disabled-panel — Nejc Zdovc
|\ \
| * | 6be56a3 - (7 days ago) Adding disabledPanel component — ryanml (ryanml/disabled-panel)
|/ /
* |   79b16fb - (6 days ago) Merge pull request #299 from ryanml/fix-298 — Nejc Zdovc
|\ \
| |/
|/|
| * c79530c - (12 days ago) Fixes #298, uses string type for amount/tokens — ryanml (ryanml/fix-298, fix-298)
* 6bf8054 - (8 days ago) v0.35.0 — Cezar Augusto (tag: v0.35.0, now-deploy-reliable)
* 3535427 - (3 weeks ago) sync v2 — Cezar Augusto
*   10f07c0 - (9 days ago) Merge pull request #300 from brave/site-banner-icon — Ryan Lanese
|\
| * da3cc4b - (11 days ago) Site banner icon update — Ross Moody
* 9064f12 - (9 days ago) Merge pull request #301 from emerick/rewards-insufficient-funds-notification — Ryan Lanese
* 5300262 - (11 days ago) Add support for insufficientFunds notification — Emerick Rogul
```
petemill added a commit that referenced this pull request Dec 11, 2018
@petemill
Update 0.59.x to latest brave-ui 0.59.x
8642d0f 
Fix brave/brave-browser#2439 - Clock AM / PM font size
Use brave-ui welcome images instead of brave-core

```
*   4e07f89 - (59 minutes ago) Merge pull request #315 from brave/revert-sync-59 — Pete Miller (HEAD -> brave-core-0.59.x, origin/brave-core-0.59.x)
|\
| * fb7deb8 - (69 minutes ago) Revert "sync v2" — Cezar Augusto
| * c5e16c7 - (69 minutes ago) Revert "Merge pull request #308 from brave/sync_img" — Cezar Augusto
|/
* c4694e2 - (20 hours ago) Merge pull request #247 from brave/c71-clock-period — Pete Miller
* a2443d8 - (4 days ago) do not count first letter if space in textareaclipboard — Cezar Augusto
* 2c16ae2 - (5 days ago) Merge pull request #308 from brave/sync_img — Cezar Augusto
* 7d9811c - (3 weeks ago) sync v2 — Cezar Augusto
* 3e3be2f - (4 days ago) update snapshot from walletSummary — Cezar Augusto
* a4c4dbd - (5 days ago) Merge pull request #309 from brave/welcome_img — Pete Miller
```
petemill added a commit that referenced this pull request Dec 11, 2018
@petemill
Update brave-ui for 0.58.x
9bba837 
Changes: https://github.com/brave/brave-ui/compare/5c2d8a0f669af2e9a68ce0fe38d49a116bc52315..861153d09e025ca98d6fae11bb51aa458c4d8519

```
* 861153d - (21 hours ago) Merge pull request #247 from brave/c71-clock-period — Pete Miller (HEAD -> brave-core-0.58.x, origin/brave-core-0.58.x)
*   4195647 - (2 hours ago) Merge pull request #316 from brave/sync-revert-58 — Pete Miller
|\
| * cad6678 - (2 hours ago) Revert "sync v2" — Cezar Augusto
| * d134401 - (2 hours ago) Revert "Merge pull request #308 from brave/sync_img" — Cezar Augusto
| * 52aef38 - (2 hours ago) Revert "allow string type for some siteBanner props" — Cezar Augusto
|/
* 5f4a8b1 - (3 hours ago) allow string type for some siteBanner props auditor: @ryanml - currentAmout, onAmountSelection and onDonate accept strings as well this is a temp fix only included in 0.58.x — Cezar Augusto
* f0569c8 - (4 days ago) do not count first letter if space in textareaclipboard — Cezar Augusto
* 69ef8be - (5 days ago) Merge pull request #308 from brave/sync_img — Cezar Augusto
* 854d181 - (3 weeks ago) sync v2 — Cezar Augusto
* b35662c - (4 days ago) update snapshot for walletSummary — Cezar Augusto
* a85206d - (5 days ago) Merge pull request #309 from brave/welcome_img — Pete Miller
```
cezaraugusto added a commit that referenced this pull request Jul 17, 2019
@cezaraugusto
Imported from brave-ui: Revert "Merge pull request #308 from brave/sy…
e6eb2dd 
…nc_img"

This reverts commit 7ea9178dd26d1d16e6882af6bb64b3500ae78332, reversing
changes made to aa520cf3cf4232b6ce4ae988209cd46a9e848918.
cezaraugusto added a commit that referenced this pull request Jul 17, 2019
@cezaraugusto
Imported from brave-ui: Merge pull request #308 from brave/sync_img
7838286 
make sync images exportable
cezaraugusto added a commit that referenced this pull request Aug 1, 2019
@cezaraugusto
Imported from brave-ui: Revert "Merge pull request #308 from brave/sy…
d884afa 
…nc_img"

This reverts commit 7ea9178dd26d1d16e6882af6bb64b3500ae78332, reversing
changes made to aa520cf3cf4232b6ce4ae988209cd46a9e848918.
cezaraugusto added a commit that referenced this pull request Aug 1, 2019
@cezaraugusto
Imported from brave-ui: Merge pull request #308 from brave/sync_img
f5ac6e2 
make sync images exportable
cezaraugusto added a commit that referenced this pull request Aug 29, 2019
@cezaraugusto
Imported from brave-ui: Revert "Merge pull request #308 from brave/sy…
832465b 
…nc_img"

This reverts commit 7ea9178dd26d1d16e6882af6bb64b3500ae78332, reversing
changes made to aa520cf3cf4232b6ce4ae988209cd46a9e848918.
cezaraugusto added a commit that referenced this pull request Aug 29, 2019
@cezaraugusto
Imported from brave-ui: Merge pull request #308 from brave/sync_img
474013f 
make sync images exportable
cezaraugusto added a commit that referenced this pull request Sep 12, 2019
@cezaraugusto
Imported from brave-ui: Revert "Merge pull request #308 from brave/sy…
234ddbc 
…nc_img"

This reverts commit 7ea9178dd26d1d16e6882af6bb64b3500ae78332, reversing
changes made to aa520cf3cf4232b6ce4ae988209cd46a9e848918.
cezaraugusto added a commit that referenced this pull request Sep 12, 2019
@cezaraugusto
Imported from brave-ui: Merge pull request #308 from brave/sync_img
66044ce 
make sync images exportable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bbondy bbondy bbondy approved these changes

Assignees

@simonhong simonhong

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@simonhong @bbondy