Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes blank panel #3201

Merged
merged 1 commit into from
Aug 19, 2019
Merged

Fixes blank panel #3201

merged 1 commit into from
Aug 19, 2019

Conversation

NejcZdovc
Copy link
Contributor

@NejcZdovc NejcZdovc commented Aug 19, 2019

Resolves brave/brave-browser#5336

Submitter Checklist:

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@NejcZdovc NejcZdovc added this to the 0.71.x - Nightly milestone Aug 19, 2019
@NejcZdovc NejcZdovc self-assigned this Aug 19, 2019
@@ -47,7 +47,8 @@ const cleanData = (state: RewardsExtension.State) => {
state = { ...state }
state.publishers = {}

if (!state.balance) {
const balance = state.balance as any
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need to convert it to any, so that TS definition doesn't return lint error. Lint error is caused because definition doesn't allow you to have undefined, but in upgrade path this is the case. We handle upgrade case here.

Copy link
Collaborator

@tmancey tmancey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM++

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rewards popup doesn't show on Nightly
2 participants