Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes blank panel #3201

Merged
merged 1 commit into from
Aug 19, 2019
+2 −1
Merged

Fixes blank panel #3201

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion components/brave_rewards/resources/extension/brave_rewards/background/storage.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,8 @@ const cleanData = (state: RewardsExtension.State) => {
state = { ...state }
state.publishers = {}

if (!state.balance) {
const balance = state.balance as any
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need to convert it to any, so that TS definition doesn't return lint error. Lint error is caused because definition doesn't allow you to have undefined, but in upgrade path this is the case. We handle upgrade case here.

if (!balance || balance.total == null) {
state.balance = defaultState.balance
}

Expand Down