Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix setting preferred color scheme logic for brave theme change #3281

Closed
wants to merge 57 commits into from
Closed
Changes from 1 commit
Commits
Show all changes
57 commits
Select commit Hold shift + click to select a range
7ab8636
Update patches from Chromium 76.0.3809.100 to Chromium 77.0.3865.42
mkarolin Jul 24, 2019
9c3f61c
Process version shouldn't create a source set.
mkarolin Jul 24, 2019
3a0fbd3
Updated chrome_constants override with the changes in the original.
mkarolin Jul 25, 2019
6af0031
OmniboxInputType::INVALID was renamed to EMPTY.
mkarolin Jul 25, 2019
f52fb34
Updated HandleExternalProtocol signature in BraveContentBrowserClient.
mkarolin Jul 31, 2019
49d45ba
Updated signature of BraveExtensionsAPIClient::ShouldHideBrowserNetwo…
mkarolin Jul 31, 2019
acbad45
AddRestoredTab now takes a tab group param.
mkarolin Jul 31, 2019
df01f0f
content/public interfaces are no longer const.
mkarolin Jul 31, 2019
6ca6be4
Removed unused source_set from the build.
mkarolin Aug 2, 2019
eebb8f5
Readded code to get top document GURL in NavigationRequest.
mkarolin Aug 2, 2019
0458ad0
Moved start of Brave services to BraveBrowserMainExtraParts::PreMainM…
mkarolin Aug 2, 2019
ad5dcc6
Moved starting of Brave services to PostBrowserStart.
mkarolin Aug 22, 2019
5021db0
PrefProvider::is_incognito_ was renamed to off_the_record_.
mkarolin Aug 2, 2019
f14c4dd
APISignature::ParseArgumentsToJSON signature change.
mkarolin Aug 5, 2019
0ef947e
ComponentLoader ctor signature change.
mkarolin Aug 5, 2019
c40cd7b
SimplifyHttpsIndicator feature is now on by default.
mkarolin Aug 5, 2019
a71ea0b
Removed Win10 specific welcome UI flow.
mkarolin Aug 6, 2019
80d1e35
Signin restructure.
mkarolin Aug 6, 2019
33b93c8
Use base::Contains instead of ContainsKey.
mkarolin Aug 6, 2019
83f775f
IOThread class has been removed.
mkarolin Aug 6, 2019
6cb0039
Fixes compilation of brave_actions_container.h
mkarolin Aug 6, 2019
fc307e0
views::BoxLayout orientation is now a class enum.
mkarolin Aug 6, 2019
6cb485d
Fixes RenderViewContextMenu override compilation.
mkarolin Aug 6, 2019
273dc52
Enable networking service.
mkarolin Aug 10, 2019
2d97254
Fixes location change of md_select_css.html.
mkarolin Aug 13, 2019
0e0629c
GridLayout::AddView now takes unique_ptr.
mkarolin Aug 13, 2019
e233e7a
GridLayout c'tor signature change.
mkarolin Aug 13, 2019
714351b
Signature change in WillCreateURLLoaderFactory in
mkarolin Aug 14, 2019
d0d3759
Removed AllowGetCookie/AllowSetCookie from BraveContentBrowserClient.
mkarolin Aug 16, 2019
51e3b17
Removed BraveNetworkDelegateBase and subclasses.
mkarolin Aug 14, 2019
35cc2cd
StringDataSource replaced StringDataPipeProducer.
mkarolin Aug 15, 2019
c93abfc
Fixes Chromium bluetooth UUID dependency bug.
mkarolin Aug 17, 2019
d34e9e0
TreeNode::GetChild and child_count were removed.
mkarolin Aug 20, 2019
7f2a620
syncer::Cryptographer c'tor signature change.
mkarolin Aug 20, 2019
6e3b456
Added a missing header include.
mkarolin Aug 20, 2019
1fd266e
paper-button has been replaced with cr-button.
mkarolin Aug 19, 2019
2d92506
Fixes missing pref in Shields settings radio buttons.
mkarolin Aug 20, 2019
8d3ff46
Transition CSS from [dark] to @media.
mkarolin Aug 20, 2019
cabb852
Disable kLookalikeUrlNavigationSuggestionsUI
mkarolin Aug 23, 2019
b808f87
Fixes BraveRequestInfo::tab_origin.
mkarolin Aug 26, 2019
879e8b2
Unit tests: Fixes MCSClient API signature changes.
mkarolin Aug 12, 2019
4bfcd5a
Unit tests: fixes GCMDriver c'tor signature change.
mkarolin Aug 12, 2019
4ee05f6
Unit tests: Fixes CreateProfileAsyncHelper signature.
mkarolin Aug 12, 2019
54ccc11
Unit test: BraveSyncServiceTest.GetDisableReasons fix.
mkarolin Aug 21, 2019
388adb9
Browser Test: SendToOmniboxAndSubmit signature change.
mkarolin Aug 21, 2019
dd0ed26
Browser Test: added missing overrides to BraveMockRenderViewContextMenu.
mkarolin Aug 21, 2019
3c73368
Browser Test: Removed SetUrlRequestMocksEnabled.
mkarolin Aug 21, 2019
0cdfe3a
Browser Test: Added a missing header include.
mkarolin Aug 21, 2019
2026836
Browser Test: Rename ContextualSuggestionsService => RemoteSuggestion…
mkarolin Aug 21, 2019
e207081
Browser Test: Allow intentional crash.
mkarolin Aug 22, 2019
a9e5a9d
Update strings for 77.0.3865.19.
mkarolin Jul 25, 2019
9e83a45
TEMPORARY: commented out code affected by Chromium commit 6811de35a39…
mkarolin Aug 16, 2019
cbef662
Fixes theme swtiching.
mkarolin Aug 27, 2019
1efd11a
Fix setting preferred color scheme logic for brave theme change
simonhong Aug 28, 2019
3a8a8fd
Fix system dark mode change affect brave theme on Win10
simonhong Aug 29, 2019
05ebaf4
CleanUp: Delete SystemThemeSupportDarkMode
simonhong Aug 29, 2019
1ffc4a8
Add dark mode change test by modifying reg value for Windows
simonhong Aug 29, 2019
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
GridLayout c'tor signature change.
Doesn't take a View* parameter any more.

Chromium change:

https://chromium.googlesource.com/chromium/src/+/c14b201aba1c9b765dc0a29c9834b53502c8b8bd

commit c14b201aba1c9b765dc0a29c9834b53502c8b8bd
Author: Scott Violet <sky@chromium.org>
Date:   Fri Jun 14 15:05:01 2019 +0000

    views: removes View* parameter to GridLayout constructor

    This parameters predates the Installed() function and can be replaced with
    the View* supplied to Installed().

    BUG=none
mkarolin committed Aug 26, 2019
commit e233e7a57447cb604d75da906ddf137218dec2d3
2 changes: 1 addition & 1 deletion browser/ui/views/translate/brave_translate_bubble_view.cc
Original file line number Diff line number Diff line change
@@ -37,7 +37,7 @@ BraveTranslateBubbleView::~BraveTranslateBubbleView() {
views::View* BraveTranslateBubbleView::BraveCreateViewBeforeTranslate() {
views::View* view = new views::View();
views::GridLayout* layout =
view->SetLayoutManager(std::make_unique<views::GridLayout>(view));
view->SetLayoutManager(std::make_unique<views::GridLayout>());
ChromeLayoutProvider* provider = ChromeLayoutProvider::Get();

constexpr int kButtonColumnSetId = 0;