Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not show the same ad more than once every hour #3296

Merged
merged 1 commit into from
Sep 3, 2019
Merged

Conversation

tmancey
Copy link
Collaborator

@tmancey tmancey commented Aug 29, 2019

Fixes brave/brave-browser#5281

Submitter Checklist:

Test Plan:

Confirm the same ads are not shown more than once per hour on mobile and desktop

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

emerick
emerick previously approved these changes Aug 29, 2019
Copy link
Contributor

@emerick emerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

emerick
emerick previously approved these changes Sep 2, 2019
Copy link
Contributor

@emerick emerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tmancey tmancey merged commit 5e7b4fa into master Sep 3, 2019
@tmancey tmancey deleted the issues/5281 branch September 3, 2019 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do not show the same ad more than once every hour
3 participants