Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handles anon wallet connected publisher case #3399

Merged
merged 1 commit into from
Sep 16, 2019
Merged

Conversation

NejcZdovc
Copy link
Contributor

@NejcZdovc NejcZdovc commented Sep 10, 2019

Resolves brave/brave-browser#5925

Submitter Checklist:

Test Plan:

plan 1:

  • enable rewards
  • claim grant
  • got to connected publisher
  • open a panel and make sure that you don't see any notice
  • make sure that you can tip this publisher and that tip is processed

plan 2:

  • enable rewards
  • claim grant
  • connect to uphold account that is not KYC
  • got to connected publisher
  • open a panel and make sure that you don't see any notice
  • make sure that you can tip this publisher and that tip is processed

plan 3:

  • enable rewards
  • connect to uphold account that is not KYC
  • got to connected publisher
  • make sure that you see notice about connected publisher
  • make sure that tip goes into pending

plan 4

  • enable rewards
  • connect to uphold KYC account
  • got to connected publisher
  • make sure that you see notice about connected publisher
  • make sure that tip goes into pending

plan 5:

  • enable rewards
  • connect to uphold KYC account
  • got to verified publisher
  • make sure that you don't see any notice
  • make sure that you can tip this publisher and that tip is processed

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@NejcZdovc NejcZdovc added this to the 0.72.x - Nightly milestone Sep 10, 2019
@NejcZdovc NejcZdovc self-assigned this Sep 10, 2019
@NejcZdovc NejcZdovc force-pushed the connected-update branch 3 times, most recently from 4a5625c to 8ec5eb7 Compare September 11, 2019 12:56
@NejcZdovc NejcZdovc marked this pull request as ready for review September 11, 2019 12:56
@NejcZdovc NejcZdovc requested a review from a team September 11, 2019 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue (0.69): Default state for connected creators needs backward compatibility
3 participants