Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handles anon wallet connected publisher case (uplift to 0.69.x) #3442

Merged
merged 1 commit into from
Sep 19, 2019

Conversation

brave-builds
Copy link
Collaborator

@brave-builds brave-builds commented Sep 16, 2019

Uplift of #3399

Approved, please ensure that before merging:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they are landing to.

After you merge:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@NejcZdovc
Copy link
Contributor

CI failures are not related to the PR

Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 0.69.x approved after deliberating with @brave/uplift-approvers. There were a few failures when running through CI/Jenkins but as @NejcZdovc mentioned via #3442 (comment), they weren't related to this specific PR.

Please make sure that all the correct labels are added and the associated issue is moved into the correct milestone.

@NejcZdovc NejcZdovc merged commit 21877c7 into 0.69.x Sep 19, 2019
@bsclifton bsclifton deleted the pr3399_connected-update_0.69.x branch October 8, 2019 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants