Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add copy_pdb as a dependency of generate_breakpad_symbols #359

Merged
merged 1 commit into from
Aug 24, 2018
Merged

Conversation

mbacchi
Copy link
Contributor

@mbacchi mbacchi commented Aug 24, 2018

This makes sure all the symbol files have been copied to the
output directory before generating breakpad symbols.

Fixes brave/brave-browser#809

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.
  • Add appropriate QA labels (QA/Needed or QA/No-QA-Needed) to include the closed issue in milestone

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

This makes sure all the symbol files have been copied to the
output directory before generating breakpad symbols.

Fixes brave/brave-browser#809
@mbacchi mbacchi self-assigned this Aug 24, 2018
@mbacchi mbacchi requested review from bbondy and simonhong August 24, 2018 19:23
@bbondy bbondy merged commit 6320847 into master Aug 24, 2018
@mbacchi mbacchi deleted the issue809 branch August 24, 2018 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Windows build produces empty symbol zip file
2 participants