Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hardens rewards tests #3699

Merged
merged 1 commit into from
Oct 15, 2019
Merged

Hardens rewards tests #3699

merged 1 commit into from
Oct 15, 2019

Conversation

NejcZdovc
Copy link
Contributor

@NejcZdovc NejcZdovc commented Oct 15, 2019

Resolves brave/brave-browser#6468

Submitter Checklist:

Test Plan:

  • covered with CI

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@NejcZdovc NejcZdovc added this to the 0.72.x - Nightly milestone Oct 15, 2019
@NejcZdovc NejcZdovc requested review from bsclifton and a team October 15, 2019 09:09
@NejcZdovc NejcZdovc self-assigned this Oct 15, 2019
Copy link
Collaborator

@tmancey tmancey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed and this change is temporary so LGTM++

@NejcZdovc NejcZdovc merged commit fd8a251 into master Oct 15, 2019
@NejcZdovc NejcZdovc deleted the fix-tests branch October 15, 2019 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Intermittent rewards browser test failure
2 participants