Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Uplift button-styles #3569 to 0.71.x #3753

Merged
merged 2 commits into from
Oct 31, 2019
Merged

Uplift button-styles #3569 to 0.71.x #3753

merged 2 commits into from
Oct 31, 2019

Conversation

petemill
Copy link
Member

@petemill petemill commented Oct 20, 2019 •
edited by bsclifton
Loading

Fixes brave/brave-browser#6398
Fixes brave/brave-browser#6573

Buttons get Brave style

Uplift #3569

Fix brave/brave-browser#6398 for 0.71.x

@petemill petemill added this to the 0.71.x - Beta milestone Oct 20, 2019
@petemill petemill requested a review from a team October 20, 2019 16:29
@petemill petemill self-assigned this Oct 20, 2019
@kjozwiak
Copy link
Member

Restarting on macOS as npm run test -- brave_browser_tests Release --output brave_browser_tests.xml failed due to the Left sig != right sig. Signature check failure. issue as per https://staging.ci.brave.com/job/brave-browser-build-pr/job/button-styles-71/1/execution/node/708/log/.

@LaurenWags also created the following issue brave/brave-browser#6545.

@kjozwiak kjozwiak added CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS CI/skip-linux labels Oct 21, 2019
@petemill
Copy link
Member Author

This now includes #3801

@bsclifton bsclifton removed CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS CI/skip-linux labels Oct 31, 2019
@bsclifton
Copy link
Member

rebased (including the auto-generated brave-browser branch) to make sure everything passes... will keep an eye on this

@bsclifton bsclifton removed the request for review from bridiver October 31, 2019 04:40
kjozwiak
kjozwiak approved these changes Oct 31, 2019
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 0.71.x approved after deliberating with @brave/uplift-approvers. Both CI/Jenkins and CI/Travis passed without any issues.

Please make sure that all the correct labels are being used and the associated issue is moved into the correct milstone.

@bsclifton bsclifton merged commit 347ca45 into 0.71.x Oct 31, 2019
@bsclifton bsclifton deleted the button-styles-71 branch October 31, 2019 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@petemill petemill

Labels
None yet
Projects
None yet
Milestone
1.0.0 - Release
Development

Successfully merging this pull request may close these issues.
3 participants
@petemill @kjozwiak @bsclifton