Reuse common licenses in copyright statements #4000
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bridiver
approved these changes
Nov 15, 2019
bridiver
requested changes
Nov 15, 2019
fmarier
force-pushed
the
francois-reuse-common-license-6856
branch
from
b2b3426
to
15f6081
Compare
bridiver
approved these changes
Nov 18, 2019
petemill
pushed a commit
that referenced
this pull request
Jul 27, 2020
* Enable widevine cdm host verification brave_enable_cdm_host_verification build flag is introduced to enable/disable cdm host verification during the build time. It will be set after checking several prerequites for verification. On MacOS, sig file is generated during the `create_dist` In contrast to MacOS, sig file generation is done during the build step on Windows. System python is needed for that because sig files can't be generated by python in gn. It was very hard to use more external modules with python of gn. Some binaries(ex, brave.exe, chrome.dll and chrome_child.dll) that are used for cdm host verification are signed in advance to generate sig files from them when signing is needed on Windows. And that signed files are copied during the `create_dist` because signing again during the `create_dist` causes mismatch of generated sig files. With this, sig files can be remained as a valid.
petemill
pushed a commit
that referenced
this pull request
Jul 28, 2020
* Enable widevine cdm host verification brave_enable_cdm_host_verification build flag is introduced to enable/disable cdm host verification during the build time. It will be set after checking several prerequites for verification. On MacOS, sig file is generated during the `create_dist` In contrast to MacOS, sig file generation is done during the build step on Windows. System python is needed for that because sig files can't be generated by python in gn. It was very hard to use more external modules with python of gn. Some binaries(ex, brave.exe, chrome.dll and chrome_child.dll) that are used for cdm host verification are signed in advance to generate sig files from them when signing is needed on Windows. And that signed files are copied during the `create_dist` because signing again during the `create_dist` causes mismatch of generated sig files. With this, sig files can be remained as a valid.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes brave/brave-browser#6856.
Submitter Checklist:
npm run lint)git rebase master(if needed).git rebase -ito squash commits (if needed).Test Plan:
Check that the following items in
brave://creditsstill have a working license when expanded:Reviewer Checklist:
After-merge Checklist:
changes has landed on.