Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade from Chromium 78.0.3904.108 to Chromium 79.0.3945.56 (1.2.x) #4117

Merged
merged 5 commits into from
Dec 4, 2019

Conversation

mkarolin
Copy link
Collaborator

@mkarolin mkarolin commented Dec 3, 2019

Fixes brave/brave-browser#6588
Related PR brave/brave-browser#7179
Uplift from #4091

Submitter Checklist:

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

simonhong and others added 3 commits December 2, 2019 20:10
Upgrade from Chromium 78.0.3904.108 to Chromium 79.0.3945.56
@mkarolin mkarolin added this to the 1.2.x - Dev milestone Dec 3, 2019
@mkarolin mkarolin self-assigned this Dec 3, 2019
@mkarolin mkarolin changed the title Upgrade from Chromium 78.0.3904.108 to Chromium 79.0.3945.56 (1.2.x) WIP: Upgrade from Chromium 78.0.3904.108 to Chromium 79.0.3945.56 (1.2.x) Dec 3, 2019
@mkarolin mkarolin marked this pull request as ready for review December 3, 2019 03:58
@NejcZdovc NejcZdovc removed their request for review December 3, 2019 06:31
Copy link
Collaborator

@tmancey tmancey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM++

mkarolin and others added 2 commits December 3, 2019 22:37
Fixes mac notarization that C79 update broke.
@mkarolin mkarolin added the CI/skip Do not run CI builds (except noplatform) label Dec 4, 2019
@mkarolin mkarolin changed the title WIP: Upgrade from Chromium 78.0.3904.108 to Chromium 79.0.3945.56 (1.2.x) Upgrade from Chromium 78.0.3904.108 to Chromium 79.0.3945.56 (1.2.x) Dec 4, 2019
@mkarolin mkarolin requested a review from a team December 4, 2019 05:39
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@bsclifton bsclifton merged commit 8d8f49c into 1.2.x Dec 4, 2019
@bsclifton bsclifton deleted the 79.0.3945.56-1.2.x branch December 4, 2019 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip Do not run CI builds (except noplatform)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants