Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade from Chromium 78.0.3904.108 to Chromium 79.0.3945.56 (1.1.x) #4119

Merged
merged 7 commits into from
Dec 4, 2019
Merged

Upgrade from Chromium 78.0.3904.108 to Chromium 79.0.3945.56 (1.1.x) #4119

merged 7 commits into from
Dec 4, 2019

Conversation

mkarolin
Copy link
Collaborator

@mkarolin mkarolin commented Dec 3, 2019 •
edited
Loading

Fixes brave/brave-browser#6588
Related PR brave/brave-browser#7181
Uplift from #4091

Submitter Checklist:

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@mkarolin mkarolin added this to the 1.1.x - Beta milestone Dec 3, 2019
@mkarolin mkarolin self-assigned this Dec 3, 2019
@mkarolin mkarolin mentioned this pull request Dec 3, 2019
Merged
28 tasks
@iefremov @mkarolin
Merge pull request #3645 from brave/ie_bye_url_request
465ffe7 
Cleanup brave shields tests and get rid of dead code.
@bsclifton @mkarolin
Merge pull request #4091 from brave/79.0.3945.56
80d946b 
Upgrade from Chromium 78.0.3904.108 to Chromium 79.0.3945.56
@mkarolin
Fixes crash in BookmarksApiUnittest.Update unit test.
8fa87c7 
The crash happens due to dereferencing an unintialized pointer.
This is fixed on master as part of
#3692, specifically in
054fd5a
but I don't think we should be uplifting all that just for a unit test
crash. So, instead just added a pointer null check.
@mkarolin mkarolin marked this pull request as ready for review December 3, 2019 19:12
@mkarolin mkarolin added CI/skip-android Do not run CI builds for Android CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 labels Dec 4, 2019
mkarolin and others added 2 commits December 3, 2019 22:36
@mkarolin
Merge pull request #4122 from brave/maxk-fix-mac-signing-postC79
2277768 
Fixes mac notarization that C79 update broke.
@mbacchi @mkarolin
Merge pull request #4129 from brave/issue_7194
4c140ee 
Fix notarization errors
@mkarolin mkarolin changed the title WIP: Upgrade from Chromium 78.0.3904.108 to Chromium 79.0.3945.56 (1.1.x) Upgrade from Chromium 78.0.3904.108 to Chromium 79.0.3945.56 (1.1.x) Dec 4, 2019
@mkarolin mkarolin requested a review from a team December 4, 2019 05:38
bsclifton
bsclifton approved these changes Dec 4, 2019
View reviewed changes
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bsclifton bsclifton merged commit 5ea1d83 into 1.1.x Dec 4, 2019
@bsclifton bsclifton deleted the 79.0.3945.56-1.1.x branch December 4, 2019 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bsclifton bsclifton bsclifton approved these changes

Assignees

@mkarolin mkarolin

Labels
CI/skip-android Do not run CI builds for Android CI/skip-macos-x64 Do not run CI builds for macOS x64
Projects
None yet
Milestone
1.1.x - Release
Development

Successfully merging this pull request may close these issues.
5 participants
@mkarolin @bsclifton @simonhong @iefremov @mbacchi