Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove "sign-in" promo that shows after saving a credit card (uplift to 1.2.x) #4170

Merged
merged 1 commit into from
Dec 6, 2019
Merged

Remove "sign-in" promo that shows after saving a credit card (uplift to 1.2.x) #4170

merged 1 commit into from
Dec 6, 2019

Conversation

brave-builds
Copy link
Collaborator

@brave-builds brave-builds commented Dec 6, 2019 •
edited by bsclifton
Loading

Uplift of #4151
Fixes brave/brave-browser#7219

Approved, please ensure that before merging:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they are landing to.

After you merge:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@brave-builds brave-builds self-assigned this Dec 6, 2019
@brave-builds brave-builds added this to the 1.2.x - Beta milestone Dec 6, 2019
@bsclifton bsclifton requested review from a team and removed request for bridiver, bbondy, kjozwiak, bsclifton, rebron and srirambv December 6, 2019 17:03
@kjozwiak
Copy link
Member

kjozwiak commented Dec 6, 2019

Restarting Linux due to https://ci.brave.com/job/brave-browser-build-pr/job/pr4151_bsc-fix-autofill-save-sign-in-promo_1.2.x/1/execution/node/579/log/. Even though this is a known issue, we're still waiting for #4171 & #4169 to complete so I'll restart this one. Linux usually doesn't take too long to rebuild.

@kjozwiak kjozwiak added CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows labels Dec 6, 2019
kjozwiak
kjozwiak approved these changes Dec 6, 2019
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.2.x approved after deliberating with @brave/uplift-approvers. Both CI/Jenkins and CI/Travis passed without any issues. Please make sure that the correct labels are being used and the associated issue is moved into the correct milestone.

@kjozwiak kjozwiak merged commit 1e6c37a into 1.2.x Dec 6, 2019
@kjozwiak kjozwiak deleted the pr4151_bsc-fix-autofill-save-sign-in-promo_1.2.x branch December 6, 2019 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@brave-builds brave-builds

Labels
CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64
Projects
None yet
Milestone
1.2.x - Release
Development

Successfully merging this pull request may close these issues.
3 participants
@brave-builds @kjozwiak @brave-browser-releases