Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 6633: Prevent click event from bubbling up to the toggle (uplift to 1.2.x) #4298

Merged
merged 1 commit into from
Jan 3, 2020
Merged

Fix 6633: Prevent click event from bubbling up to the toggle (uplift to 1.2.x) #4298

merged 1 commit into from
Jan 3, 2020

Conversation

bsclifton
Copy link
Member

@bsclifton bsclifton commented Jan 3, 2020 •
edited
Loading

Uplift of #4042
Fixes brave/brave-browser#6633

Approved, please ensure that before merging:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they are landing to.

After you merge:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@bsclifton
Merge pull request #4042 from brave/push_messaging_relaunch_fix
d8be5ec 
Fix 6633: Prevent click event from bubbling up to the toggle
@bsclifton bsclifton added this to the 1.2.x - Release milestone Jan 3, 2020
@bsclifton bsclifton requested a review from a team January 3, 2020 05:03
@bsclifton bsclifton self-assigned this Jan 3, 2020
kjozwiak
kjozwiak approved these changes Jan 3, 2020
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.2.x approved after deliberating with @brave/uplift-approvers. Both CI/Jenkins and CI/Travis passed without any issues. Please make sure that all the correct labels are added and the associated issue is moved into the correct milestone.

@kjozwiak kjozwiak merged commit c487796 into 1.2.x Jan 3, 2020
@kjozwiak kjozwiak deleted the bsc-fix-restart-button branch January 3, 2020 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@bsclifton bsclifton

Labels
None yet
Projects
None yet
Milestone
1.2.x - Release
Development

Successfully merging this pull request may close these issues.
2 participants
@bsclifton @kjozwiak