Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Tab Page WebUI: Rewards widget does not display Ads item if non-ads region #4445

Merged
merged 1 commit into from
Jan 28, 2020

Conversation

petemill
Copy link
Member

Fix brave/brave-browser#7944

Submitter Checklist:

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@petemill petemill self-assigned this Jan 28, 2020
Copy link
Contributor

@ryanml ryanml left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks good, please check CI

@bsclifton
Copy link
Member

CI got stuck; just gave it a kick 😄 Checking out code now...

Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@bsclifton bsclifton added this to the 1.5.x - Nightly milestone Jan 28, 2020
@petemill petemill merged commit 9d1391a into master Jan 28, 2020
@petemill petemill deleted the ntp-ads-unsupported-region branch January 28, 2020 14:53
petemill added a commit that referenced this pull request Jan 29, 2020
New Tab Page WebUI: Rewards widget does not display Ads item if non-ads region
This was referenced Jan 29, 2020
petemill added a commit that referenced this pull request Jan 29, 2020
New Tab Page WebUI: Rewards widget does not display Ads item if non-ads region
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NTP SI - ads item in NTP rewards widget is shown for unsupported ads region message
3 participants