Fixes setting to disable Brave Ads ad conversion detection isn't working #4839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kylehickinson
requested changes
Mar 5, 2020
| @@ -14,7 +14,7 @@ | |||
| - (void)confirmAction:(const std::string &)uuid creativeSetId:(const std::string &)creative_set_id confirmationType:(const ads::ConfirmationType &)confirmation_type; | |||
| - (void)eventLog:(const std::string &)json; | |||
| - (void)getCreativeAdNotifications:(const std::vector<std::string> &)categories callback:(ads::OnGetCreativeAdNotificationsCallback)callback; | |||
| - (void)getAdConversions:(const std::string &)url callback:(ads::OnGetAdConversionsCallback)callback; | |||
| - (void)getAdConversions:callback:(ads::OnGetAdConversionsCallback)callback; | |||
There was a problem hiding this comment.
Have to remove callback: here (will fail to compile)
tmancey
added
CI/skip-android
|
CI failed on macOS, restarting macOS |
tmancey
removed
CI/skip-android
4 tasks
4 tasks
|
LGTM Verification passed on
Verified that ads that have conversions are shown when toggle is ON |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves brave/brave-browser#8536
Submitter Checklist:
npm run lint)git rebase master(if needed).git rebase -ito squash commits (if needed).Test Plan:
See brave/brave-browser#8536
Reviewer Checklist:
After-merge Checklist:
changes has landed on.