Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert the disabling of WebSQL after finding extension breakage #4842

Merged
merged 1 commit into from
Mar 5, 2020

Conversation

bsclifton
Copy link
Member

@bsclifton bsclifton commented Mar 5, 2020

Speed dial extension was affected; may impact others too.

Fixes brave/brave-browser#8542
Unfixes brave/brave-browser#7522


Revert "Merge pull request #4463 from brave/disable_websql"

This reverts commit a50fa1d, reversing
changes made to cd4edd3.

Submitter Checklist:

Test Plan:

See brave/brave-browser#8542

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

Speed dial extension was affected; may impact others too.

Fixes brave/brave-browser#8542

-----

Revert "Merge pull request #4463 from brave/disable_websql"

This reverts commit a50fa1d, reversing
changes made to cd4edd3.
@bsclifton bsclifton added this to the 1.7.x - Nightly milestone Mar 5, 2020
@bsclifton bsclifton requested a review from jumde March 5, 2020 05:11
@bsclifton bsclifton self-assigned this Mar 5, 2020
@bsclifton bsclifton added the CI/skip Do not run CI builds (except noplatform) label Mar 5, 2020
@bsclifton bsclifton merged commit f7ab26b into master Mar 5, 2020
@bsclifton bsclifton deleted the bsc-revert-disable-websql branch March 5, 2020 05:15
@bsclifton
Copy link
Member Author

Needs uplift to 1.6 after we test on Nightly. Queueing new Nightly now...

@kjozwiak
Copy link
Member

kjozwiak commented Mar 5, 2020

Verification PASSED on macOS 10.15.3 x64 using the following build

Brave | 1.7.44 Chromium: 80.0.3987.132 (Official Build) nightly (64-bit)
-- | --
Revision | fcea73228632975e052eb90fcf6cd1752d3b42b4-refs/branch-heads/3987@{#974}
OS | macOS Version 10.15.3 (Build 19D76)

Screen Shot 2020-03-05 at 11 21 00 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip Do not run CI builds (except noplatform)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

certain extensions breaking due to WebSQL being disabled
3 participants