Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewards tests now use v2 endpoint for data #491

Merged
merged 1 commit into from
Sep 24, 2018
Merged

Rewards tests now use v2 endpoint for data #491

merged 1 commit into from
Sep 24, 2018

Conversation

jasonrsadler
Copy link
Contributor

Fixes brave/brave-browser#1246

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.
  • Add appropriate QA labels (QA/Needed or QA/No-QA-Needed) to include the closed issue in milestone

Test Plan:

Run npm run test -- brave_browser_tests --filter=BraveRewardsBrowserTest.* and ensure build is successful and tests pass

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

@NejcZdovc NejcZdovc merged commit 93d51b3 into brave:master Sep 24, 2018
@jasonrsadler jasonrsadler deleted the fix/rewards_tests_prefix branch September 24, 2018 12:45
NejcZdovc added a commit that referenced this pull request Sep 24, 2018
Rewards tests now use v2 endpoint for data
@NejcZdovc
Copy link
Contributor

master 93d51b3
0.55 b81a458

@bbondy bbondy added this to the 0.55.x - Release milestone Jan 14, 2019
petemill pushed a commit to petemill/brave-core that referenced this pull request Jul 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rewards tests should now use v2 endpoints
3 participants